Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up market actor unit tests #300

Merged
merged 20 commits into from
May 2, 2022
Merged

Clean-up market actor unit tests #300

merged 20 commits into from
May 2, 2022
+1,043 −1,421

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented May 2, 2022 •
edited
Loading

  • Partially implement actor.checkState
  • Remove clippy exceptions (eg allow(clippy::too_many_arguments).
  • Use constant actor addresses.
  • Remove code duplication.

@lemmih lemmih marked this pull request as ready for review May 2, 2022 12:41
@lemmih lemmih changed the title [WIP] Clean-up market actor unit tests Clean-up market actor unit tests May 2, 2022
LesnyRumcajs
LesnyRumcajs requested changes May 2, 2022
View reviewed changes
Copy link
Contributor

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good amount of cleanup! Would be nice to use full names in variable names. I believe it would make the code more readable and self-explanatory, reducing the mental overhead of translation. Any decent editor will autocomplete anyway.

@lemmih lemmih merged commit 52c3f48 into master May 2, 2022
@lemmih lemmih deleted the chainsafe/clean-up-market-actor-unit-tests branch May 2, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmattic elmattic elmattic left review comments

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lemmih @LesnyRumcajs @elmattic