Enable Forward Compatibility methods and add tests #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubuxu
force-pushed
the
feat/forward-compat-tests
branch
from
c83a0a3 to
4da1b1f
Compare
Codecov Report
@@ Coverage Diff @@
## master #650 +/- ##
==========================================
+ Coverage 82.21% 82.42% +0.21%
==========================================
Files 88 88
Lines 18306 18308 +2
==========================================
+ Hits 15050 15091 +41
+ Misses 3256 3217 -39
|
anorth
approved these changes
Sep 14, 2022
Kubuxu
force-pushed
the
feat/forward-compat-tests
branch
from
661a748 to
fa17fb6
Compare
added 4 commits
September 19, 2022 16:14
Signed-off-by: Jakub Sztandera <[email protected]>
Signed-off-by: Jakub Sztandera <[email protected]>
Signed-off-by: Jakub Sztandera <[email protected]>
Signed-off-by: Jakub Sztandera <[email protected]>
Kubuxu
force-pushed
the
feat/forward-compat-tests
branch
from
fa17fb6 to
d4b6998
Compare
Signed-off-by: Jakub Sztandera <[email protected]>
anorth
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
LGTM. I would like @ZenGround0 to take a look if possible, but if he doesn't get to it in a couple of days, let's merge and he can review afterwards.
ZenGround0
approved these changes
Sep 20, 2022
| @@ -546,7 +550,7 @@ fn upgrade_bad_post_dispute() { | |||
| let store = &MemoryBlockstore::new(); | |||
| let policy = Policy::default(); | |||
| let (v, sector_info, worker, miner_id, deadline_index, partition_index, _) = | |||
| create_miner_and_upgrade_sector(store); | |||
| create_miner_and_upgrade_sector(store, false); | |||
There was a problem hiding this comment.
Why not test v2 for these tests?
There was a problem hiding this comment.
because it is unrelated to the changes, I can add these tests if we want to.
Kubuxu
pushed a commit
that referenced
this pull request
Sep 22, 2022
Signed-off-by: Jakub Sztandera <[email protected]>
Kubuxu
pushed a commit
that referenced
this pull request
Sep 22, 2022
Signed-off-by: Jakub Sztandera <[email protected]> Signed-off-by: Jakub Sztandera <[email protected]>
shamb0
pushed a commit
to shamb0/builtin-actors
that referenced
this pull request
Jan 31, 2023
) * Enable Forward Compatibility methods and add tests Signed-off-by: Jakub Sztandera <[email protected]> * Address review Signed-off-by: Jakub Sztandera <[email protected]> * Add tests for ReplicaUpdate2 Signed-off-by: Jakub Sztandera <[email protected]> * Remove duplicate pub use Signed-off-by: Jakub Sztandera <[email protected]> * Test v2 pre-commit in integration test Signed-off-by: Jakub Sztandera <[email protected]> Signed-off-by: Jakub Sztandera <[email protected]>
shamb0
pushed a commit
to shamb0/builtin-actors
that referenced
this pull request
Jan 31, 2023
Signed-off-by: Jakub Sztandera <[email protected]> Signed-off-by: Jakub Sztandera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #521
Resolves: #13