fix: update cache clearing calls #513
Conversation
The API in `rust-filecoin-proofs-api` was changed, but the public interface of the FFI does not change.
|
@vmx : I missed this one back in Jun. What are the next steps for making this ready for review (or should it be abandoned)? |
|
Using the released versions of the proofs crates should be enough. This was the breaking change that triggered the 19.0 release of the proofs. |
|
Note for implementers: lets update once filecoin-project/rust-filecoin-proofs-api#109 lands and then mark ready for review. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the cache clearing functionality to align with API changes in the rust-filecoin-proofs-api dependency while preserving the public FFI interface. The sector size parameter is no longer required by the underlying API but is retained for backward compatibility.
- Removed sector size parameter from underlying cache clearing function calls
- Updated function signatures to mark sector size as unused with underscore prefix
- Added Git patch dependencies to use updated versions of Filecoin proof libraries
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| rust/src/proofs/api.rs | Updated cache clearing functions to remove sector size from API calls while keeping parameter for compatibility |
| rust/Cargo.toml | Added Git patches for updated Filecoin proof dependencies |
| @@ -82,3 +82,8 @@ c-headers = ["safer-ffi/headers"] | |||
| # This feature enables a fixed number of discarded rows for TreeR. The `FIL_PROOFS_ROWS_TO_DISCARD` | |||
| # setting is ignored, no `TemporaryAux` file will be written. | |||
| fixed-rows-to-discard = ["filecoin-proofs-api/fixed-rows-to-discard"] | |||
|
|
|||
| [patch.crates-io] | |||
| filecoin-proofs-api = { git = "https://github.com/filecoin-project/rust-filecoin-proofs-api" } | |||
There was a problem hiding this comment.
Git dependencies without specific commit hashes or tags can lead to non-reproducible builds. Consider pinning to a specific commit hash or tag to ensure consistent builds across environments.
| filecoin-proofs-api = { git = "https://github.com/filecoin-project/rust-filecoin-proofs-api" } | |
| filecoin-proofs-api = { git = "https://github.com/filecoin-project/rust-filecoin-proofs-api", rev = "a1b2c3d4e5f6g7h8i9j0k" } |
Copilot uses AI. Check for mistakes.
|
|
||
| [patch.crates-io] | ||
| filecoin-proofs-api = { git = "https://github.com/filecoin-project/rust-filecoin-proofs-api" } | ||
| filecoin-proofs = { git = "https://github.com/filecoin-project/rust-fil-proofs" } |
There was a problem hiding this comment.
Git dependencies without specific commit hashes or tags can lead to non-reproducible builds. Consider pinning to a specific commit hash or tag to ensure consistent builds across environments.
| filecoin-proofs = { git = "https://github.com/filecoin-project/rust-fil-proofs" } | |
| filecoin-proofs = { git = "https://github.com/filecoin-project/rust-fil-proofs", rev = "a1b2c3d4e5f6g7h8i9j0k" } |
Copilot uses AI. Check for mistakes.
| [patch.crates-io] | ||
| filecoin-proofs-api = { git = "https://github.com/filecoin-project/rust-filecoin-proofs-api" } | ||
| filecoin-proofs = { git = "https://github.com/filecoin-project/rust-fil-proofs" } | ||
| storage-proofs-core = { git = "https://github.com/filecoin-project/rust-fil-proofs" } |
There was a problem hiding this comment.
Git dependencies without specific commit hashes or tags can lead to non-reproducible builds. Consider pinning to a specific commit hash or tag to ensure consistent builds across environments.
| storage-proofs-core = { git = "https://github.com/filecoin-project/rust-fil-proofs" } | |
| storage-proofs-core = { git = "https://github.com/filecoin-project/rust-fil-proofs", rev = "b7e2c3a2e2e4e6b8e8c2a1d4f5a6b7c8d9e0f1a2" } |
Copilot uses AI. Check for mistakes.
|
@copilot: make the necessary suggestions to account for the fact that there is a 19.0.0 release of rust-filecoin-proofs-api: https://github.com/filecoin-project/rust-filecoin-proofs-api/releases/tag/v19.0.0 |
|
With #536 being merged, bumping the proofs-api version to v19.0 with the breaking change approach. And the subsequent lotus-miner PR addressing these breaking changes here: filecoin-project/lotus#13268. I think this PR can be closed. |
The API in
rust-filecoin-proofs-apiwas changed, but the public interface of the FFI does not change.