Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chain exchange and partial message metrics #852

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

masih
Copy link
Member

@masih masih commented Jan 27, 2025

Add metrics that measure various aspects of chain exchange and partial messages, including:

  • The number of messages pending partial messages.
  • The total number instances with a partial message.
  • The chain exchange broadcast count.
  • The length of broadcast chain.
  • The time spent on chain exchange validation.
  • Qualify existing GPBFT validation metrics with partial message attribute.
  • The number of duplicate partial messages qualified with equivocation attribute.

Fixes: #812

@masih masih requested a review from Kubuxu January 27, 2025 16:21
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 75.32468% with 19 lines in your changes missing coverage. Please review.

Project coverage is 67.10%. Comparing base (bae93e2) to head (cc97a49).

Files with missing lines Patch % Lines
partial_msg.go 0.00% 12 Missing ⚠️
chainexchange/pubsub.go 87.80% 5 Missing ⚠️
internal/measurements/attributes.go 83.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #852      +/-   ##
==========================================
- Coverage   67.21%   67.10%   -0.11%     
==========================================
  Files          83       84       +1     
  Lines        9055     9105      +50     
==========================================
+ Hits         6086     6110      +24     
- Misses       2430     2454      +24     
- Partials      539      541       +2     
Files with missing lines Coverage Δ
chainexchange/metrics.go 100.00% <100.00%> (ø)
host.go 64.82% <100.00%> (-0.05%) ⬇️
metrics.go 90.62% <100.00%> (+3.12%) ⬆️
internal/measurements/attributes.go 83.33% <83.33%> (ø)
chainexchange/pubsub.go 72.41% <87.80%> (+1.16%) ⬆️
partial_msg.go 55.78% <0.00%> (-2.88%) ⬇️

... and 3 files with indirect coverage changes

@masih masih enabled auto-merge January 27, 2025 18:14
@masih masih disabled auto-merge January 27, 2025 18:14
@masih masih self-assigned this Jan 27, 2025
Add metrics that measure various aspects of chain exchange and partial
messages, including:
 * The number of messages pending partial messages.
 * The total number instances with a partial message.
 * The chain exchange broadcast count.
 * The length of broadcast chain.
 * The time spent on chain exchange validation.
 * Qualify existing GPBFT validation metrics with partial message
   attribute.
 * The number of duplicate partial messages qualified with equivocation
 attribute.

Fixes: #812
@masih masih force-pushed the masih/partial-msg-chainex-metrics branch from cc97a49 to cfbbd79 Compare January 29, 2025 12:06
@masih masih added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit 81059b1 Jan 29, 2025
12 checks passed
@masih masih deleted the masih/partial-msg-chainex-metrics branch January 29, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add metrics to capture the state of partial messages
2 participants