feat: batch computation of ECChain Keys in chainexchange #918
+249
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubuxu
force-pushed
the
feat/batch-chain-hash
branch
from
23a5807 to
cd6d991
Compare
Adjust the for loop not to repeat the full chain The EqualExportedValues is required as we never call explicit Key these values, leaving cached key empty. Signed-off-by: Jakub Sztandera <[email protected]>
It conflicts with partial message validation Signed-off-by: Jakub Sztandera <[email protected]>
Kubuxu
force-pushed
the
feat/batch-chain-hash
branch
from
cd6d991 to
68cdac0
Compare
masih
approved these changes
Mar 17, 2025
Signed-off-by: Jakub Sztandera <[email protected]>
|
There is still room for optimization (the hashing allocates like crazy), so if there is a need, it could be optimized further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the for loop not to repeat the full chain
The EqualExportedValues is required as we never call explicit Key these
values, leaving cached key empty.
Resolves #831