feat: tstore fevm test #12849
Open
feat: tstore fevm test #12849
+361
−140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Because the network upgrade does not happen the tests currently fail so they are commented with what needs to change once the network upgrade can be wired in.
…xpected correct result happens.
|
2025-01-29 conversation: this will be ready for review once filecoin-project/go-state-types#340 lands |
rvagg
reviewed
Jan 30, 2025
rvagg
reviewed
Jan 30, 2025
rvagg
reviewed
Jan 30, 2025
|
seems good to me, just need dependencies to be updated |
|
GST-release that includes filecoin-project/go-state-types#340 has been published here: https://github.com/filecoin-project/go-state-types/releases/tag/v0.16.0-rc3 |
Co-authored-by: Rod Vagg <[email protected]>
Co-authored-by: Rod Vagg <[email protected]>
|
I changed the version of go-state-types to rc3 and ran I also ran itests pass locally for me! at the moment github tests are still pending |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
filecoin-project/go-state-types#340
The PR 340 in go state types is needed for the tests in this PR to pass.
Proposed Changes
add tests for transient storage that asserts that there is no support for transient storage in the evm, migrates to nv16, then asserts that there is support for transient storage after the migration
Additional Info
filecoin-project/FIPs#1084
Checklist
Before you mark the PR ready for review, please make sure that: