Code Quality: Replaced DllImport calls with CsWin32 generations for DPI calculation operations #17118
+3
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lamparter
force-pushed
the
cswin32/GetDpiForWindow
branch
from
8542c54 to
f21227d
Compare
yaira2
reviewed
May 11, 2025
|
Looks fine to me. |
yaira2
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Steps used to test these changes
AppModel.AppWindowDPIpropertyGetDpiForWindowis already being used in some places however the legacy method pointing to aDllImportcall remains in the Win32 PInvoke helper.This PR removes it from the helper and replaces the final reference to
Win32PInvoke.GetDpiForWindow()with the appropriate method generated by CsWin32.