Skip to content

Code Quality: Fixed tab key navigation in Omnibar #17219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 27, 2025
Merged

Code Quality: Fixed tab key navigation in Omnibar #17219

merged 7 commits into from
Jun 27, 2025

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Jun 26, 2025

Resolved / Related Issues

Steps used to test these changes

  • Fixed tab key navigation in Omnibar
  • Fixed crash with actions in Command mode

Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, behavior wise.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the brief summary of this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a try catch when loading actions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jun 27, 2025
@yaira2 yaira2 merged commit 9d914f2 into main Jun 27, 2025
9 checks passed
@yaira2 yaira2 deleted the ya/FixedTabNav branch June 27, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants