Code Quality: Refactored VisualStates for InfoPane #17416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x5bfa
commented
Aug 7, 2025
yaira2
force-pushed
the
5bfa/CQ-InfoPaneVisualStates
branch
from
ed6f1a8 to
53cd654
Compare
|
The visual states don't seem to be setting the minimum widths for the info pane. |
yaira2
reviewed
Aug 11, 2025
yaira2
reviewed
Aug 11, 2025
yaira2
added
changes requested
0x5bfa
force-pushed
the
5bfa/CQ-InfoPaneVisualStates
branch
2 times, most recently
from
29f1231 to
6b8494e
Compare
|
The visual states aren't working correctly. 
|
0x5bfa
force-pushed
the
5bfa/CQ-InfoPaneVisualStates
branch
from
50e1017 to
de12090
Compare
|
PTAL. Now it is working as expected. |
yaira2
force-pushed
the
main
branch
2 times, most recently
from
97999e5 to
806f922
Compare
yaira2
force-pushed
the
5bfa/CQ-InfoPaneVisualStates
branch
from
de12090 to
1afe863
Compare
yaira2
force-pushed
the
5bfa/CQ-InfoPaneVisualStates
branch
from
1afe863 to
e906aff
Compare
yaira2
changed the title
yaira2
added
ready to merge
|
Is that a misclick? |
|
No, I was hoping you could check the behavior on your end. That said, I tested extensively on my side, and the behavior seems consistent with |
Josh65-2201
approved these changes
Sep 28, 2025
|
Thank you for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
The reason why visual state manager failed to apply these changes within XAML was probably because the enums are inside the class. Now everything works as expected, removing extra lines of code.
Important
You should "Hide whitespace" in the diff view
Steps used to test these changes