Skip to content

Code Quality: Prepared shared server infrastructure - #19054

Open
hez2010 wants to merge 7 commits into
files-community:mainfrom
hez2010:feature/server-foundation
Open

hez2010 wants to merge 7 commits into
files-community:mainfrom
hez2010:feature/server-foundation

Conversation

@hez2010

@hez2010 hez2010 commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Prepare the shared server infra for the upcoming server migration work: server organization, notifications, async completion handling, deferred UI loading, and shared file locking.

Depends on #19053

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

  • Closes #

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Opened Files ...
  2. ...

@hez2010
hez2010 force-pushed the feature/server-foundation branch 7 times, most recently from 20e7b30 to 0529601 Compare October 26, 2026 14:05
@hez2010
hez2010 force-pushed the feature/server-foundation branch from 0529601 to e068f04 Compare October 26, 2026 14:33
@hez2010
hez2010 marked this pull request as ready for review October 26, 2026 14:35
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-26T14:35:07.110082Z
We couldn’t complete this review. Comment @codex review to try again.
e068f04 Draft marked ready
🔒 Security Review ⚠️ Failed 2026-10-26T14:35:14.768300Z
We couldn’t complete this review. Comment @codex security review to try again.
e068f04 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@chatgpt-codex-connector

Copy link
Copy Markdown

The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins.

@hez2010

hez2010 commented Oct 26, 2026

Copy link
Copy Markdown
Member Author

@yair100 PTAL. This is the last part of fundamental work before we can start moving shared functionalities to the server.

yair100
yair100 previously approved these changes Oct 26, 2026

@yair100 yair100 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yair100 yair100 added the ready to merge Pull requests that are approved and ready to merge label Oct 26, 2026
Comment thread src/Files.App/App.xaml.cs
Comment thread src/Files.App/Views/Properties/LibraryPage.xaml.cs Outdated
Comment thread src/Files.App/Views/Properties/DetailsPage.xaml.cs Outdated
Comment thread src/Files.App/Extensions/DispatcherQueueExtensions.cs
Comment thread src/Files.App/Views/Layouts/BaseLayoutPage.cs
Comment thread src/Files.App.Server/Catalogs/InitializationCache.cs Outdated
Comment thread src/Files.App.Server/ServerEvents.cs Outdated
Comment thread src/Files.App.Server/FileWriteLease.cs
Comment thread src/Files.App.Server/Initialization/StartupServices.cs
Comment thread src/Files.App/Helpers/Application/AppMemoryHelper.cs
@hez2010

hez2010 commented Oct 27, 2026 •

Copy link
Copy Markdown
Member Author

Addressed the feedbacks. PTAL.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants