-
Notifications
You must be signed in to change notification settings - Fork 143
refactor: Add TypeScript support #1142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1142 +/- ##
=======================================
Coverage 83.22% 83.22%
=======================================
Files 66 66
Lines 2795 2795
Branches 332 332
=======================================
Hits 2326 2326
Misses 423 423
Partials 46 46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapproving this - it's a lot easier to see the changes now that merge conflicts have been resolved 👍🏼
@coopernetes @06kellyjac I suppose this could go into the first release candidate for v2? Or should we deal with the few remaining TS PRs and get it all in a single release? #960 #1063 #1065
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, moving to providing js and types from dist
should be done in v2.
https://github.com/yeoman/generator/blob/main/package.json#L23-L37
Also there's several useful things within git-proxy which we expect people to directly import from files e.g. config, which would break & should be exported properly.
package.json
Outdated
@@ -2,6 +2,8 @@ | |||
"name": "@finos/git-proxy", | |||
"version": "1.19.2", | |||
"description": "Deploy custom push protections and policies on top of Git.", | |||
"main": "dist/index.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These files don't live in dist
due to ./scripts/build-for-publish.sh
considering the majority of commits are just update merges and there's 2 commits with the same message a rebase & cleanup would be ideal |
|
…it-proxy into pr/fabiovincenzi/1142
Signed-off-by: Fabio Vincenzi <[email protected]>
5d176a2
to
8a1ebcf
Compare
Wondering if this is ready to go? 🤔 |
Hi @06kellyjac, what do you think about the latest changes? |
Given that @JamieSlome was covered by the Citi CCLA at the time the commits were made we can ignore the EasyCLA bot in this particular case. A @finos/git-proxy-maintainers should be able to force merge this PR. Please email [email protected] with any questions or concerns. |
Overview
This PR introduces TypeScript to git-proxy and refactors relevant code to support it.
Changelog
Thanks to @jescalada for the work on fixing CI issues on G-Research#31, which helped guide the necessary changes in this PR.
Related issue: #927
Note: Restored from deleted fork
This PR recreates the original PR #929, which was automatically closed due to accidental fork deletion.
** For discussions and reviews:** See the original PR #929
All commits are identical to the original with preserved git history.