-
Notifications
You must be signed in to change notification settings - Fork 143
refactor(ts): refactor db
module to use TS and ESM
#938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
…-refactor-db-module
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #938 +/- ##
===========================================
- Coverage 61.88% 51.70% -10.18%
===========================================
Files 49 48 -1
Lines 1805 1671 -134
Branches 0 53 +53
===========================================
- Hits 1117 864 -253
- Misses 688 790 +102
- Partials 0 17 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jescalada not sure which PR caused all the conflicts but can you tidy your branch up and then re-request a review from me? Thanks!
The db and config modules were modified as part of #960 so closing for now. If further conversion or refactoring is needed, we can either re-open or start a new PR. |
@coopernetes - can you confirm the suggested version bump for the merge of #960? |
Fixes #964.
This PR refactors the
db
module to use TS and ESM. It builds on top of #929 (the latest commits haven't been merged in yet).Original PR comment:
Edit: I've managed to get the tests to pass by using
mocha
on the plugin tests andts-mocha
on everything else. The only problem is that some recent tests are flaky on local (they seem to pass reliably in the CI):Edit 2: Fixed flaky tests in #945.
Thank you!