fix(mck): compare semantic float values numerically - #1024
Merged
Merged
Conversation
✅ Deploy Preview for angry-raman-7c44f6 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compare admitted finite
FloatLiteralvalues numerically in MCK@semanticcases, including nested values. Retain byte-exact@spellingchecks and show the original Ion texts in semantic diffs. This implements decision beadmorphir-kl86.Add cross-lexeme case
values-0048for JSON and YAML4e0against Ion(float "4.0"), update the draft contract and schema count, and record a separate append-only Rust exchange.Verification
mise run mck:check: 156 cases; 187 accepted schema fences, 13 expected rejects.mise run mck:run-rust: 992 pass, 0 fail; full inventory.mise run mck:run: 834 TypeScript pass, 158 declared capability skips, 0 fail.cargo test -p morphir-mck --lib: 217 pass.cargo test -p morphir-mck --test schema: 7 pass.cargo test -p morphir --test mck_schema --test mck_run: 3 and 32 pass.cargo clippy -p morphir-mck -p morphir --all-targets -- -D warningsandcargo fmt --all --checkpass.values-float-equality-rust.ndjsoncaptured twice byte-identically; 10 passes.Refs #946