Use the species finding voice in the template fallback - #154
Open
InfinitePortaldev wants to merge 1 commit into
Open
Use the species finding voice in the template fallback#154InfinitePortaldev wants to merge 1 commit into
InfinitePortaldev wants to merge 1 commit into
Conversation
The species and stat driven voices from fiorastudio#130 never got called anywhere, so template-fallback findings still use the generic phrasing table. This wires buildObserverPrompt to phraseFindingForCompanion so the deterministic fallback speaks in species voice with the stat lead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While poking at the fallback bubbles I noticed phraseFindingForCompanion from #130 has no callers, so the species finding voices never actually reach users. Template-fallback findings still go through the generic phrasing table.
This wires it in. A Robot's fallback now reads like "Diagnostic: ... advanced without sufficient verification", geese honk, and the peak-stat lead comes through. Tests on the touched paths pass (observer, observer-integration, scrub-wiring, both phrasings suites).
If there's interest I also have a small species tic layer for the non-finding template lines (the Robot beeps once for approval, twice for concern, that sort of thing). Happy to send it as a follow-up.