Skip to content

feat(ci): add CODEOWNERS for skill reviewer automation - #208

Open
joehan wants to merge 3 commits into
mainfrom
feat/skills-codeowners
Open

joehan wants to merge 3 commits into
mainfrom
feat/skills-codeowners

Conversation

@joehan

@joehan joehan commented Oct 8, 2026

Copy link
Copy Markdown
Member

Description

Adds .github/CODEOWNERS to automate reviewer assignments for Firebase Agent Skills across the repository.

Whenever a pull request modifies files in a specific skill directory under skills/, GitHub will automatically request review from the corresponding domain team / maintainers.

Non-Blocking Guarantee

Reviews requested by CODEOWNERS are strictly non-blocking per the main branch ruleset (require_code_owner_review: false). Any repository maintainer with write access can approve and merge PRs even if skill owners do not respond.

Adds .github/CODEOWNERS to auto-request reviews from domain teams when changes are made to specific skills.
Reviews requested by CODEOWNERS are non-blocking per the main branch ruleset (require_code_owner_review: false).

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a .github/CODEOWNERS file to define code ownership for various Firebase Agent Skills directories. The review feedback suggests an improvement to add ownership for the .github/ directory itself to ensure repository configurations and workflows are routed to the core maintainers.

Comment thread .github/CODEOWNERS Outdated
Comment on lines +7 to +8
# Default maintainers for the skills catalog
/skills/ @firebase/firebase-skills-contributors

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To ensure that changes to repository configurations, GitHub Actions workflows, and the CODEOWNERS file itself are automatically routed to the core maintainers for review, consider adding ownership for the /.github/ directory.

# CI/CD and Repository Configuration
/.github/ @firebase/firebase-skills-contributors

# Default maintainers for the skills catalog
/skills/ @firebase/firebase-skills-contributors

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants