Repository navigation
Conversation
Adds .github/CODEOWNERS to auto-request reviews from domain teams when changes are made to specific skills. Reviews requested by CODEOWNERS are non-blocking per the main branch ruleset (require_code_owner_review: false).
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a .github/CODEOWNERS file to define code ownership for various Firebase Agent Skills directories. The review feedback suggests an improvement to add ownership for the .github/ directory itself to ensure repository configurations and workflows are routed to the core maintainers.
Comment on lines
+7
to
+8
| # Default maintainers for the skills catalog | ||
| /skills/ @firebase/firebase-skills-contributors |
Contributor
There was a problem hiding this comment.
To ensure that changes to repository configurations, GitHub Actions workflows, and the CODEOWNERS file itself are automatically routed to the core maintainers for review, consider adding ownership for the /.github/ directory.
# CI/CD and Repository Configuration
/.github/ @firebase/firebase-skills-contributors
# Default maintainers for the skills catalog
/skills/ @firebase/firebase-skills-contributors
rachelsaunders
approved these changes
Oct 8, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
.github/CODEOWNERSto automate reviewer assignments for Firebase Agent Skills across the repository.Whenever a pull request modifies files in a specific skill directory under
skills/, GitHub will automatically request review from the corresponding domain team / maintainers.Non-Blocking Guarantee
Reviews requested by CODEOWNERS are strictly non-blocking per the
mainbranch ruleset (require_code_owner_review: false). Any repository maintainer with write access can approve and merge PRs even if skill owners do not respond.