Skip to content

refactor(firebase-ai-logic-basics): split service management from SDK setup and move references - #217

Open
AustinBenoit wants to merge 1 commit into
mainfrom
ai-logic/2-core-structure
Open

AustinBenoit wants to merge 1 commit into
mainfrom
ai-logic/2-core-structure

Conversation

@AustinBenoit

@AustinBenoit AustinBenoit commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary

@AustinBenoit
AustinBenoit added this pull request to stack #218 October 9, 2026 14:48

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly updates and reorganizes the Firebase AI Logic documentation, introducing comprehensive setup guides for Android (Kotlin), iOS (Swift), Flutter (Dart), and Web (JavaScript). It covers essential topics such as backend provisioning, App Check enforcement, and model rollout with Remote Config. The review feedback correctly identifies compilation errors in the iOS setup guide where the App Check provider factories are incorrectly named AppAttestProviderFactory and DeviceCheckProviderFactory instead of AppCheckAppAttestProviderFactory and AppCheckDeviceCheckProviderFactory.

Comment thread skills/firebase-ai-logic-basics/references/sdk/setup/ios_setup.md Outdated
Comment thread skills/firebase-ai-logic-basics/references/sdk/setup/ios_setup.md Outdated
@AustinBenoit
AustinBenoit force-pushed the ai-logic/2-core-structure branch 3 times, most recently from c78b3d2 to 07030a8 Compare October 9, 2026 16:13
@AustinBenoit

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request comprehensively updates the Firebase AI Logic skill documentation and platform-specific setup guides for Android, iOS, Flutter, and Web. The changes restructure the core guide into Service Management and SDK Setup sections, detail App Check enforcement (including replay protection and secure debug token handling), and migrate references to the latest SDK versions and entry points. As there are no review comments, I have no feedback to provide.

@AustinBenoit
AustinBenoit force-pushed the ai-logic/2-core-structure branch from 07030a8 to 6626699 Compare October 9, 2026 16:51
@AustinBenoit
AustinBenoit removed this pull request from stack #218 October 9, 2026 16:53
@AustinBenoit
AustinBenoit added this pull request to stack #223 October 9, 2026 16:53
@AustinBenoit AustinBenoit changed the title refactor(firebase-ai-logic-basics): split service management from SDK setup and usage refactor(firebase-ai-logic-basics): split service management from SDK setup and move references Oct 9, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant