You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[BUG] RemoteConfig unit tests fail in non-English (e.g., Korean) Locales due to Date Parsing #1196
Operating System version: macOS (Apple Silicon, ko_KR locale)
Firebase SDK version: 9.7.0 (Current development branch)
Library version: N/A
Firebase Product: Remote Config
[REQUIRED] Step 3: Describe the problem
Steps to reproduce:
The unit tests for Remote Config fail when the system's default locale is set to a non-English language (e.g., Korean). This is due to RemoteConfigUtil using SimpleDateFormat without an explicit Locale.ENGLISH, causing parsing errors or string comparison mismatches against English date formats.
Error Output:
org.junit.ComparisonFailure: expected:<...NODE","updateTime":"[Tue, 08 Dec] 2020 15:49:51 UTC",...>
but was:<...NODE","updateTime":"[화, 08 12월] 2020 15:49:51 UTC",...>
Caused by: java.text.ParseException: Unparseable date: "Tue, 08 Dec 2020 15:49:51 UTC"
at java.base/java.text.DateFormat.parse(DateFormat.java:427)
at com.google.firebase.remoteconfig.RemoteConfigUtil.convertFromUtcDateFormat(RemoteConfigUtil.java:91)
Relevant Code:
The issue occurs in RemoteConfigUtil.java. There are 4 methods using SimpleDateFormat without an explicit Locale. To ensure consistent behavior across different system locales, all instances of SimpleDateFormat should be instantiated with Locale.ENGLISH.
Hi @ashish-kothari@rathovarun1032, I've opened PR #1199 to fix this issue. It adds Locale.ENGLISH to the four SimpleDateFormat instances as described above — CLA is green and all tests pass locally. Could you take a look when you have a chance? Thanks!
Activity
fix(rc): Set explicit English locale for date parsing
jungsehui202 commentedon Jul 8, 2026
Hi @ashish-kothari @rathovarun1032, I've opened PR #1199 to fix this issue. It adds Locale.ENGLISH to the four SimpleDateFormat instances as described above — CLA is green and all tests pass locally. Could you take a look when you have a chance? Thanks!