[FDL] Remove firebase-dynamic-links module #7094

rlazo · 2025-06-30T22:47:11Z

Removing deprecated firebase-dynamic-links SDK as the FDL service is being turned down in August 2025

github-actions · 2025-06-30T22:47:25Z

Firebase AI Mock Responses Check ⚠️

A newer major version of the mock responses for Firebase AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v14.2

github-actions · 2025-06-30T22:47:27Z

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

gemini-code-assist

Summary of Changes

Hello @rlazo, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request removes the firebase-dynamic-links module as the Firebase Dynamic Links service is being shut down in August 2025. This change involves removing the module from the subprojects configuration.

Highlights

Removal: Removes the deprecated firebase-dynamic-links module.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request removes the deprecated firebase-dynamic-links module. The review suggests removing the firebase-dynamic-links module in addition to the firebase-dynamic-links:ktx subproject to fully complete the removal.

github-actions · 2025-06-30T23:04:22Z

Test Results

1 074 files + 16 1 074 suites +16 36m 22s ⏱️ +16s
5 871 tests - 115 5 849 ✅ - 114 21 💤 - 1 1 ❌ ±0
12 433 runs +398 12 390 ✅ +400 42 💤 - 2 1 ❌ ±0

For more details on these failures, see this check.

Results for commit 8e74293. ± Comparison against base commit 4744473.

This pull request removes 115 tests.

com.google.firebase.dynamiclinks.DynamicLinkTest ‑ testAndroidParameters_Builder_Constructor
com.google.firebase.dynamiclinks.DynamicLinkTest ‑ testAndroidParameters_Builder_Constructor_PackageName
com.google.firebase.dynamiclinks.DynamicLinkTest ‑ testAndroidParameters_Builder_SetFallbackLink
com.google.firebase.dynamiclinks.DynamicLinkTest ‑ testAndroidParameters_Builder_SetMinimumVersion
com.google.firebase.dynamiclinks.DynamicLinkTest ‑ testBuilder_BuildDynamicLink
com.google.firebase.dynamiclinks.DynamicLinkTest ‑ testBuilder_BuildShortDynamicLink_WithSuffix
com.google.firebase.dynamiclinks.DynamicLinkTest ‑ testBuilder_SetDomainUriPrefix
com.google.firebase.dynamiclinks.DynamicLinkTest ‑ testBuilder_SetDynamicLinkDomain
com.google.firebase.dynamiclinks.DynamicLinkTest ‑ testBuilder_SetLink
com.google.firebase.dynamiclinks.DynamicLinkTest ‑ testBuilder_SetLongLink
…

♻️ This comment has been updated with latest results.

google-oss-bot · 2025-06-30T23:42:06Z

Size Report ¹

Affected Products

No changes between base commit (4744473) and merge commit (8ed83c6).

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/XGHuG8mSP5.html

google-oss-bot · 2025-07-01T00:04:10Z

Coverage Report ¹

Affected Products

firebase-database
Overall coverage changed from 50.16% (4744473) to 50.14% (8ed83c6) by -0.02%.
Filename Base (4744473) Merge (8ed83c6) Diff
DoubleNode.java 100.00% 88.24% -11.76%
firebase-firestore
Overall coverage changed from 45.78% (4744473) to 45.77% (8ed83c6) by -0.00%.
Filename Base (4744473) Merge (8ed83c6) Diff
DeleteMutation.java 95.24% 90.48% -4.76%
firebase-sessions
Overall coverage changed from 66.56% (4744473) to 66.67% (8ed83c6) by +0.11%.
Filename Base (4744473) Merge (8ed83c6) Diff
RemoteSettings.kt 87.32% 88.73% +1.41%
firebase-messaging
Filename Base (4744473) Merge (8ed83c6) Diff
FirebaseMessaging.java 75.60% 76.80% +1.20%
Metadata.java 41.27% 36.51% -4.76%

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/lTpf4Ps4Su.html

google-oss-bot · 2025-07-01T00:12:33Z

Startup Time Report ¹

The report is too large (117,119 chars) to be displayed on GitHub. Please check this report on GCS.

https://storage.googleapis.com/firebase-sdk-metric-reports/Bsf8hHKJio/index.html

Similar to how it was done in iOS, see https://github.com/firebase/firebase-ios-sdk/pull/14978/files#diff-1bdf397aa76371fb849872633c85183eacb595ac83b13b3a651863c7e82ea8b3

github-actions · 2025-07-02T23:07:08Z

plugins test results

68 tests 68 ✅ 1m 9s ⏱️
12 suites 0 💤
12 files 0 ❌

Results for commit 8e74293.

♻️ This comment has been updated with latest results.

rlazo · 2025-07-02T23:07:32Z

Metalava SemVer check is expected to fail since one module is removed so the api comparison is made with an non-existing api.txt file.

Remove firebase-dynamic-links module

f1a1819

gemini-code-assist bot reviewed Jun 30, 2025

View reviewed changes

rlazo changed the title ~~Remove firebase-dynamic-links module~~ [FDL] Remove firebase-dynamic-links module Jun 30, 2025

Remove firebase-dynamic-links and references

b90c750

Fix spurious changes generated by Jules

87d0de0

rlazo marked this pull request as ready for review July 2, 2025 21:09

rlazo requested review from eldhosembabu, VinayGuthal and davidmotson July 2, 2025 21:09

eldhosembabu approved these changes Jul 2, 2025

View reviewed changes

rlazo added 2 commits July 2, 2025 17:27

Add back the changelog

6a37614

Similar to how it was done in iOS, see https://github.com/firebase/firebase-ios-sdk/pull/14978/files#diff-1bdf397aa76371fb849872633c85183eacb595ac83b13b3a651863c7e82ea8b3

Merge branch 'main' into remove-dynamic-links

5784455

Remove leftover code in smoke-tests

8e74293

rlazo merged commit 5959a50 into main Jul 3, 2025
588 of 597 checks passed

rlazo deleted the remove-dynamic-links branch July 3, 2025 04:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[FDL] Remove firebase-dynamic-links module #7094

[FDL] Remove firebase-dynamic-links module #7094

Uh oh!

rlazo commented Jun 30, 2025

Uh oh!

github-actions bot commented Jun 30, 2025

Uh oh!

github-actions bot commented Jun 30, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

github-actions bot commented Jun 30, 2025 •

edited

Loading

Uh oh!

google-oss-bot commented Jun 30, 2025 •

edited

Loading

Uh oh!

google-oss-bot commented Jul 1, 2025 •

edited

Loading

`firebase-database`

`firebase-firestore`

`firebase-sessions`

`firebase-messaging`

Uh oh!

google-oss-bot commented Jul 1, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 2, 2025 •

edited

Loading

Uh oh!

rlazo commented Jul 2, 2025

Uh oh!

Uh oh!

Uh oh!

[FDL] Remove firebase-dynamic-links module #7094

[FDL] Remove firebase-dynamic-links module #7094

Uh oh!

Conversation

rlazo commented Jun 30, 2025

Uh oh!

github-actions bot commented Jun 30, 2025

Firebase AI Mock Responses Check ⚠️

Uh oh!

github-actions bot commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 PRs merging into main branch

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

github-actions bot commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

google-oss-bot commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

Test Logs

Uh oh!

google-oss-bot commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report 1

Affected Products

firebase-database

firebase-firestore

firebase-sessions

firebase-messaging

Test Logs

Uh oh!

google-oss-bot commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Startup Time Report 1

Uh oh!

github-actions bot commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

plugins test results

Uh oh!

rlazo commented Jul 2, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 30, 2025 •

edited

Loading

github-actions bot commented Jun 30, 2025 •

edited

Loading

google-oss-bot commented Jun 30, 2025 •

edited

Loading

Size Report ¹

google-oss-bot commented Jul 1, 2025 •

edited

Loading

Coverage Report ¹

`firebase-database`

`firebase-firestore`

`firebase-sessions`

`firebase-messaging`

google-oss-bot commented Jul 1, 2025 •

edited

Loading

Startup Time Report ¹

github-actions bot commented Jul 2, 2025 •

edited

Loading