Add unit tests for chat history in FirebaseAI #14955
Conversation
This commit introduces two new unit tests to `FirebaseAI/Tests/Unit/ChatTests.swift`: 1. `testChatHistory()`: This test verifies the chat history functionality when starting with a pre-existing history. It ensures that new messages (both user and model) are correctly appended to the history. 2. `testChatHistoryWithEmptyInitialHistory()`: This test covers the scenario where the chat starts with an empty history. It validates that the first user message and the subsequent model response correctly initialize and populate the history. Both tests utilize `MockURLProtocol` to simulate network responses, ensuring reliable and isolated testing of the chat history logic.
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
Generated by 🚫 Danger |
The previous commit for adding chat history tests (feat/add-chat-history-tests) resulted in a CI failure due to a type mismatch in the MockURLProtocol.requestHandler. The handler expected an AsyncLineSequence<URL.AsyncBytes>? for the response body, but the tests were providing [Data]. This commit corrects the issue by: - Modifying the testChatHistory() and testChatHistoryWithEmptyInitialHistory() functions in FirebaseAI/Tests/Unit/ChatTests.swift. - The mock network response data is now provided as an AsyncStream<String>. This aligns with the pattern used in the existing testMergingText() function, which uses fileURL.lines (an AsyncLineSequence<String>) and passes CI. This change ensures that the mock data is supplied in a format that MockURLProtocol can correctly process, resolving the type error.
This commit introduces two new unit tests to
FirebaseAI/Tests/Unit/ChatTests.swift:testChatHistory(): This test verifies the chat history functionality when starting with a pre-existing history. It ensures that new messages (both user and model) are correctly appended to the history.testChatHistoryWithEmptyInitialHistory(): This test covers the scenario where the chat starts with an empty history. It validates that the first user message and the subsequent model response correctly initialize and populate the history.Both tests utilize
MockURLProtocolto simulate network responses, ensuring reliable and isolated testing of the chat history logic.