fix(ai): Fix fraction seconds bug with ProtoDuration #15410
+166
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a minor bug I came across in the
ProtoDuration
decoding. It's not a emergency release worthy bug, but it can produce an incorrect nanosecond value (ie; instead of123000000
it currently produces123
). In practicality, this means that withinLiveServerGoingAwayNotice
, thetimeLeft
field could be off by +-1 second.Tests have been added for
ProtoDuration
as well, to help avoid this in the future.