Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix (auth-compat): reliably detect Capacitor/Cordova environment #8756

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dpa99c
Copy link

@dpa99c dpa99c commented Feb 4, 2025

This PR resolves #8755 by adding a check for the Capacitor/cordova global namespaces on the window object as an alternative to checking the user agent string to confirm whether the current runtime environment is a Webview withing a Capacitor/Cordova hybrid mobile app.

…mespaces since user agent string matching is fragile and no longer works on modern iPad since iPadOS 13 changed the UA string to look like desktop macOS
Copy link

google-cla bot commented Feb 4, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

changeset-bot bot commented Feb 4, 2025

⚠️ No Changeset found

Latest commit: fb65b48

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dlarocque
Copy link
Contributor

Hi @dpa99c, thanks you for opening a PR! Could you please sign the Google CLA, and create a changeset with yarn changeset add? I believe this should be patch bump for @firebase/auth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auth-compat module incorrectly detects Capacitor/Cordova environment on iPad
2 participants