Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the UTF-8 encoding in string sorting #8782

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Feb 10, 2025

The fix on string sorting is creating performance issue. Reverting the change back before a patch is added.

@milaGGL milaGGL requested review from a team as code owners February 10, 2025 18:21
Copy link

changeset-bot bot commented Feb 10, 2025

🦋 Changeset detected

Latest commit: 1d42607

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v6.1

@dconeybe
Copy link
Contributor

drive-by comment: don't forget a changeset entry

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 10, 2025

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (4e6a5c6)Merge (90d4e77)Diff
    browser381 kB380 kB-334 B (-0.1%)
    main589 kB589 kB-372 B (-0.1%)
    module381 kB380 kB-334 B (-0.1%)
    react-native381 kB380 kB-334 B (-0.1%)
  • @firebase/firestore-lite

    TypeBase (4e6a5c6)Merge (90d4e77)Diff
    browser112 kB112 kB-393 B (-0.4%)
    main154 kB154 kB-421 B (-0.3%)
    module112 kB112 kB-393 B (-0.4%)
    react-native112 kB112 kB-393 B (-0.3%)
  • bundle

    15 size changes

    TypeBase (4e6a5c6)Merge (90d4e77)Diff
    firestore (CSI Auto Indexing Disable and Delete)271 kB271 kB-196 B (-0.1%)
    firestore (CSI Auto Indexing Enable)271 kB271 kB-196 B (-0.1%)
    firestore (Persistence)303 kB302 kB-159 B (-0.1%)
    firestore (Query Cursors)250 kB249 kB-159 B (-0.1%)
    firestore (Query)247 kB247 kB-159 B (-0.1%)
    firestore (Read data once)235 kB235 kB-159 B (-0.1%)
    firestore (Read Write w Persistence)327 kB327 kB-159 B (-0.0%)
    firestore (Realtime updates)237 kB237 kB-159 B (-0.1%)
    firestore (Transaction)214 kB214 kB-196 B (-0.1%)
    firestore (Write data)214 kB214 kB-196 B (-0.1%)
    firestore-lite (Query Cursors)103 kB103 kB-196 B (-0.2%)
    firestore-lite (Query)99.4 kB99.2 kB-196 B (-0.2%)
    firestore-lite (Read data once)74.8 kB74.6 kB-196 B (-0.3%)
    firestore-lite (Transaction)100 kB99.9 kB-196 B (-0.2%)
    firestore-lite (Write data)84.4 kB84.2 kB-196 B (-0.2%)

  • firebase

    TypeBase (4e6a5c6)Merge (90d4e77)Diff
    firebase-compat.js791 kB791 kB-154 B (-0.0%)
    firebase-firestore-compat.js339 kB338 kB-154 B (-0.0%)
    firebase-firestore-lite.js131 kB130 kB-393 B (-0.3%)
    firebase-firestore.js439 kB439 kB-334 B (-0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/fY4AaW3G73.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 10, 2025

Size Analysis Report 1

This report is too large (481,346 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/7zAvY33dIV.html

@milaGGL milaGGL requested a review from a team as a code owner February 10, 2025 19:53
'firebase': patch
---

Reverted a change to use UTF-8 encoding in string comparisons which caused a performance issue.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another drive-by comment: Append Fixes #NNNN to allow interested parties to click through to the github issue and understand more context.

@milaGGL milaGGL merged commit 3418ef8 into main Feb 11, 2025
49 checks passed
@milaGGL milaGGL deleted the mila/revert-string-utf8-encoding-feature branch February 11, 2025 19:35
@google-oss-bot google-oss-bot mentioned this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants