-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert the UTF-8 encoding in string sorting #8782
Conversation
🦋 Changeset detectedLatest commit: 1d42607 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Vertex AI Mock Responses Check
|
drive-by comment: don't forget a changeset entry |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (481,346 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
.changeset/slimy-chicken-mix.md
Outdated
'firebase': patch | ||
--- | ||
|
||
Reverted a change to use UTF-8 encoding in string comparisons which caused a performance issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another drive-by comment: Append Fixes #NNNN
to allow interested parties to click through to the github issue and understand more context.
The fix on string sorting is creating performance issue. Reverting the change back before a patch is added.