Make remote config version available through API #9176
+34
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
🦋 Changeset detectedLatest commit: e30c884 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Firebase JS SDK lacks realtime updates support.
I'm not sure why.
But I checked, how Android SDK is working, and implemented my own wrapper around
@firebase/remote-config, which supports realtime updates. One thing I miss though — is remote config version extraction from the.../firebase:fetchendpoint response, in order to use it later in.../firebase:streamFetchInvalidationsrequest payload.I am patching local
@firebase/remote-configpackage usingpnpm patch, but I need to redo the patch every time new version came out.So I decided it worth trying to make a PR. I figured, that if you are planning to add realtime updates support into JS SDK in future, you will have to add this change anyways.
It doesn't introduce any changes from regular user's perspective, not breaking, nor minor. So it could be new patch version. And it will help me a lot, so I could remove my local package patching.
Thank you for your attention!