feat(core): Add module overrides system #1184
Draft
+411
−34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a feature which enables module overrides.
Since we're supporting Angular components via AngularFire, which wraps Firebase exports in zones, our own internal core implementation does not know about these, and thus usage from Angular will call the Firebase exports and potentially cause issues with reactivity, SSR etc.
This PR will allow the Angular implementation to set a module implementation which core will use if available, otherwise it'll fallback to
firebase/auth
.