Skip to content

Fix Dart GitHub Actions logic for resolving packages with Flutter dependencies#1275

Merged
jhuleatt merged 5 commits into
multi-counterfrom
fix-dart-ci-flutter-6813502532237530128
Apr 17, 2026
Merged

Fix Dart GitHub Actions logic for resolving packages with Flutter dependencies#1275
jhuleatt merged 5 commits into
multi-counterfrom
fix-dart-ci-flutter-6813502532237530128

Conversation

@jhuleatt
Copy link
Copy Markdown
Collaborator

Setting up flutter in test_dart.yml workflow, and updating dart pub get to run conditionally as flutter pub get only if sdk: flutter is detected in pubspec.yaml, ensuring that it resolves dependencies without issue for dart projects that may include flutter packages.


PR created automatically by Jules for task 6813502532237530128 started by @jhuleatt

Co-authored-by: jhuleatt <3759507+jhuleatt@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pubspec.lock file, resulting in the downgrade of the matcher and test_api packages. The reviewer pointed out that the core logic intended for this PR is missing from the commit and that these lock file changes appear to be unintended side effects of dependency resolution in an older environment. Additionally, a suspicious Flutter SDK version requirement was identified in the lock file.

Comment on lines +591 to +594
sha256: "12956d0ad8390bbcc63ca2e1469c0619946ccb52809807067a7020d57e647aa6"
url: "https://pub.dev"
source: hosted
version: "0.12.19"
version: "0.12.18"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The changes described in the pull request (modifying test_dart.yml and adding conditional logic for flutter pub get) are missing from this diff. The current changes only update pubspec.lock, resulting in a downgrade of matcher (0.12.19 to 0.12.18) and test_api (0.7.10 to 0.7.9). This indicates that the core logic of the fix was not included in the commit, and the lock file update appears to be an unintended side effect of a dependency re-resolution in an older environment. Additionally, the lock file contains a suspicious SDK requirement for Flutter (>=3.38.0) in the sdks section, which does not correspond to any existing Flutter version.

google-labs-jules Bot and others added 4 commits April 17, 2026 15:13
…ailure

Co-authored-by: jhuleatt <3759507+jhuleatt@users.noreply.github.com>
…ailure

Co-authored-by: jhuleatt <3759507+jhuleatt@users.noreply.github.com>
…ailure

Co-authored-by: jhuleatt <3759507+jhuleatt@users.noreply.github.com>
Co-authored-by: jhuleatt <3759507+jhuleatt@users.noreply.github.com>
@jhuleatt jhuleatt merged commit fe0a2fd into multi-counter Apr 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant