Fix Dart GitHub Actions logic for resolving packages with Flutter dependencies#1275
Conversation
Co-authored-by: jhuleatt <3759507+jhuleatt@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Code Review
This pull request updates the pubspec.lock file, resulting in the downgrade of the matcher and test_api packages. The reviewer pointed out that the core logic intended for this PR is missing from the commit and that these lock file changes appear to be unintended side effects of dependency resolution in an older environment. Additionally, a suspicious Flutter SDK version requirement was identified in the lock file.
| sha256: "12956d0ad8390bbcc63ca2e1469c0619946ccb52809807067a7020d57e647aa6" | ||
| url: "https://pub.dev" | ||
| source: hosted | ||
| version: "0.12.19" | ||
| version: "0.12.18" |
There was a problem hiding this comment.
The changes described in the pull request (modifying test_dart.yml and adding conditional logic for flutter pub get) are missing from this diff. The current changes only update pubspec.lock, resulting in a downgrade of matcher (0.12.19 to 0.12.18) and test_api (0.7.10 to 0.7.9). This indicates that the core logic of the fix was not included in the commit, and the lock file update appears to be an unintended side effect of a dependency re-resolution in an older environment. Additionally, the lock file contains a suspicious SDK requirement for Flutter (>=3.38.0) in the sdks section, which does not correspond to any existing Flutter version.
…ailure Co-authored-by: jhuleatt <3759507+jhuleatt@users.noreply.github.com>
…ailure Co-authored-by: jhuleatt <3759507+jhuleatt@users.noreply.github.com>
…ailure Co-authored-by: jhuleatt <3759507+jhuleatt@users.noreply.github.com>
Co-authored-by: jhuleatt <3759507+jhuleatt@users.noreply.github.com>
Setting up flutter in test_dart.yml workflow, and updating
dart pub getto run conditionally asflutter pub getonly ifsdk: flutteris detected inpubspec.yaml, ensuring that it resolves dependencies without issue for dart projects that may include flutter packages.PR created automatically by Jules for task 6813502532237530128 started by @jhuleatt