Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(py): generate schemas.py from genkit-schema.json using datamodel-codegen #1807 #1808

Merged
merged 1 commit into from
Feb 11, 2025
Merged

feat(py): generate schemas.py from genkit-schema.json using datamodel-codegen #1807 #1808

merged 1 commit into from
Feb 11, 2025

Conversation

yesudeep
Copy link
Contributor

@yesudeep yesudeep commented Feb 3, 2025 •
edited
Loading

feat: generate schema.py from genkit-schema.json using datamodel-codegen #1807

ISSUE: #1807

CHANGELOG:

  • Add a bin/generate_schema_types script that generates the Pydantic
    schema.py module.
  • Update the pre-commit hooks to ensure this file gets regenerated
    routinely.
  • Remove timestamp to ensure we do not treat a file with identical
    content differently preventing the hassles of updating this file per
    commit.

Checklist (if applicable):

@github-actions github-actions bot added feature New feature or request python Python config labels Feb 3, 2025
@yesudeep yesudeep force-pushed the yesudeep/feat/big-ticket branch from 5cbb967 to 8959150 Compare February 3, 2025 21:08
@yesudeep yesudeep requested a review from pavelgj February 3, 2025 21:09
@yesudeep yesudeep self-assigned this Feb 3, 2025
@yesudeep yesudeep added this to the py-0.1.0 milestone Feb 3, 2025
@yesudeep yesudeep changed the title feat: generate types.py from genkit-schema.json using datamodel-codegen #1807 feat(py): generate types.py from genkit-schema.json using datamodel-codegen #1807 Feb 3, 2025
@yesudeep yesudeep force-pushed the yesudeep/feat/big-ticket branch from 8959150 to 2c1dd96 Compare February 3, 2025 21:21
@yesudeep yesudeep requested a review from apascal07 February 3, 2025 21:49
@yesudeep yesudeep force-pushed the yesudeep/feat/big-ticket branch 6 times, most recently from 7723ab8 to 2735ceb Compare February 4, 2025 23:01
Irillit
Irillit reviewed Feb 5, 2025
View reviewed changes
py/bin/generate_schema_types Outdated Show resolved Hide resolved
py/pyproject.toml Outdated Show resolved Hide resolved
@yesudeep yesudeep force-pushed the yesudeep/feat/big-ticket branch 3 times, most recently from c2d6f0b to b80ca3e Compare February 6, 2025 07:56
@yesudeep yesudeep changed the title feat(py): generate types.py from genkit-schema.json using datamodel-codegen #1807 feat(py): generate schema.py from genkit-schema.json using datamodel-codegen #1807 Feb 6, 2025
@yesudeep yesudeep marked this pull request as draft February 6, 2025 08:05
@yesudeep yesudeep force-pushed the yesudeep/feat/big-ticket branch 3 times, most recently from ac0e079 to 14c7e87 Compare February 11, 2025 02:42
@yesudeep yesudeep changed the title feat(py): generate schema.py from genkit-schema.json using datamodel-codegen #1807 feat(py): generate schemas.py from genkit-schema.json using datamodel-codegen #1807 Feb 11, 2025
@yesudeep yesudeep force-pushed the yesudeep/feat/big-ticket branch 6 times, most recently from 5cef31a to cd73759 Compare February 11, 2025 17:38
@yesudeep
feat(py): generate schemas.py from genkit-schema.json using datam…
c96d4c2 
…odel-codegen #1807

ISSUE: #1807

CHANGELOG:
- [ ] Add a `bin/generate_schema_types` script that generates the Pydantic
  `schemas.py` module.
- [ ] Not updating the pre-commit hooks since the generated file
  requires manual patching.
- [ ] Remove timestamp to ensure we do not treat a file with identical
content differently preventing the hassles of updating this file per
commit.
@yesudeep yesudeep force-pushed the yesudeep/feat/big-ticket branch from cd73759 to c96d4c2 Compare February 11, 2025 17:51
@yesudeep yesudeep marked this pull request as ready for review February 11, 2025 17:54
@yesudeep yesudeep merged commit 3a3f69f into main Feb 11, 2025
7 checks passed
@yesudeep yesudeep deleted the yesudeep/feat/big-ticket branch February 11, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelgj pavelgj pavelgj approved these changes

@apascal07 apascal07 apascal07 left review comments

@Irillit Irillit Irillit left review comments

Assignees

@yesudeep yesudeep

Labels
config feature New feature or request python Python
Projects
Genkit Backlog
Status: Done
Milestone
py-0.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@yesudeep @pavelgj @apascal07 @Irillit