fix(js/testapps/express): Fixed express testapp endpoints #3642
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #3641, currently the endpoints in the express testapp do not work and therefore the documented
curl
commands do not work as documented in the file's comments. Therefore this PR makes the following changes to fix this:context.auth.username
check inside thejokeFlow
to only perform the check if the object exists (meaning it ran through an endpoint that uses theauth
contextProvider
and thus doesn't crash if accessed by an endpoint not using thecontextProvider
).POST /jokeFlow
endpoint to not rely on iterating throughai.flows
because thef.name
attribute previously being used does not equal the flow's name anymore so simplifying the logic to ensure it's registered and thecurl
command works.selectedModel
constant towards the top of the file to allow for easier swapping of the model between providers for make debugging easier.8080
because port5000
is used by Mac OS X Control Center so moved it to make development easier across OSes.Tested by running the server and executing all the provided
curl
commands in the comments and callingcurl http://localhost:8080/jokeFlow?stream=true -d '{"data": "banana"}' -H "content-type: application/json" -H "authorization: hi"
to simulate an authenticated call that fails to ensure that thePERMISSION_DENIED
error is properly returned in this usecase.Checklist (if applicable):