remove old api endpoint; implement "internal_transfer" #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

canvas-warwick wants to merge 1 commit into fireblocks:master from canvas-warwick:canvas-warwick

canvas-warwick commented Nov 9, 2023

Pull Request Description

It appears there are two obsolete endpoints in the code: transfer_to_subaccount and transfer_from_subaccount

Fixes (link to the issue here)
I have deleted these and replaced with the newer version internal_transfer

Type of change

Please delete options that are not relevant.

[ X ] Bug fix (non-breaking change which fixes an issue)
[ X ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

not tested

Checklist:

[ X ] I have performed a self-review of my own code
I have made corresponding changes to the documentation
Any dependent changes have been merged and published in downstream modules
I have added corresponding labels to the PR


          remove old api endpoint; implement "internal_transfer"

b5f3091

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet