WIP: changes to merge gossip2 branch #5154

ravyu-jump · 2025-05-16T21:50:03Z

setup type defs and fn defintions for parsing
parsers for ping and pong
progress
rx ping/pong, tx ping, ping/pong serializers, helper functions, coalesce ping and pong into one type

…sce ping and pong into one type

src/discof/gossip/fd_gossip_tile.c

src/flamenco/gossip/fd_crds.h

src/flamenco/gossip/fd_gossip.c

src/flamenco/gossip/fd_ping_tracker.c

src/flamenco/gossip/fd_gossip_types.h

src/flamenco/gossip/fd_gossip_msg.h

src/flamenco/gossip/fd_gossip.c

src/flamenco/gossip/fd_gossip.h

src/flamenco/gossip/fd_gossip_msg_parse.c

src/flamenco/gossip/fd_crds_value.h

src/flamenco/gossip/fd_ping_tracker.h

src/flamenco/gossip/fd_gossip.c

src/flamenco/gossip/fd_gossip_msg.h

src/flamenco/gossip/fd_crds_value.h

mmcgee-jump · 2025-05-28T19:21:47Z

src/flamenco/gossip/fd_crds_value.h

+  } version;
+
+  struct {
+    /* WARNING: in gossip contact info message,


Not useful comment, fd_ip4_port_t is clearly host order

fd_ip4_port_t is clearly host order

The fd_ip4_port_t type def has comments saying network order

mmcgee-jump · 2025-05-28T19:22:16Z

src/flamenco/gossip/fd_crds_value.h

+
+struct fd_gossip_crds_vote {
+  ulong slot;
+  uchar vote_tower_index;


Is this already stored in the key? vote_index ?

src/flamenco/gossip/fd_ping_tracker.h

mmcgee-jump · 2025-05-29T23:48:01Z

src/flamenco/gossip/fd_ping_tracker.h

+   Assumes both token and hash are the starting address of a 32byte region of
+   memory */
+void
+fd_ping_tracker_hash_ping_token( uchar *       hash,


nits: would flip the argument order, and name out_hash, out args are usually last by convention

mmcgee-jump · 2025-05-29T23:49:20Z

src/flamenco/gossip/fd_ping_tracker.c

+void
+fd_ping_tracker_hash_ping_token( uchar *       hash,
+                                 uchar const * token ) {
+  fd_sha256_t sha[1];


probably needs a ping_tracker const * ping_tracker arg, and to use ping_tracker->sha

src/discof/gossip/fd_gossip_tile.c

mmcgee-jump · 2025-05-29T23:52:22Z

src/discof/gossip/fd_gossip_tile.c

+  fd_gossip_tile_ctx_t * gossip_ctx = (fd_gossip_tile_ctx_t *)ctx;
+
+  ulong packet_sz = payload_sz + sizeof(fd_ip4_udp_hdrs_t);
+  gossip_ctx->net_out->chunk = fd_dcache_compact_next( gossip_ctx->net_out->chunk, packet_sz, gossip_ctx->net_out->chunk0, gossip_ctx->net_out->wmark );


Do this at the end after fd_stem_publish (by convention, incase we return early etc)

mmcgee-jump · 2025-05-29T23:52:57Z

src/discof/gossip/fd_gossip_tile.c

+  /* TODO: ip4 net_id? */
+
+  /* Inject payload */
+  fd_memcpy( packet + sizeof(fd_ip4_udp_hdrs_t), payload, payload_sz );


Not good. Payload should already be constructed in the right place.

mmcgee-jump · 2025-05-29T23:53:44Z

src/discof/gossip/fd_gossip_tile.c

+
+  /* Publish fragment */
+  ulong tspub = fd_frag_meta_ts_comp( fd_tickcount() );
+  ulong sig   = fd_disco_netmux_sig( peer_address->addr, peer_address->port, peer_address->addr, DST_PROTO_OUTGOING, sizeof(fd_ip4_udp_hdrs_t) );


Last arg is ignored, should probably be set to 0.

src/discof/gossip/fd_gossip_tile.c

mmcgee-jump · 2025-05-30T00:11:22Z

src/flamenco/gossip/fd_crds_value.h

+
+FD_PROTOTYPES_BEGIN
+long
+fd_crds_value_wallclock( fd_crds_value_t const * value );


Are these functions needed? Looks like it's trivial to access the value

mmcgee-jump · 2025-05-30T00:22:24Z

src/flamenco/gossip/fd_gossip_msg.c

+#include "fd_gossip_msg.h"
+#include "fd_gossip_types.h"
+void
+fd_gossip_msg_init( fd_gossip_message_t * msg ) {


Why? Should never need to call this

mmcgee-jump · 2025-05-30T00:22:31Z

src/flamenco/gossip/fd_gossip.h

@@ -121,6 +144,8 @@ fd_gossip_set_identity( fd_gossip_t * gossip,
      periodically rotated, with one new peer entering and one old peer
      leaving, based on stake weights.

+   now is the current time in nanoseconds.


dupe comment

mmcgee-jump · 2025-05-30T00:32:27Z

src/flamenco/gossip/fd_gossip_msg.h

+
+  /* For CRDS composites, this holds information about the CRDS values necessary
+     to perform an insertion into the CRDS and signature verification */
+  ulong crds_cnt; /* number of CRDS values in the message, if any */


I think this is a bit confused. Why are the CRDS lifted out from the union to the parent type here? A ping/pong does not have CRDS.

mmcgee-jump · 2025-05-30T00:34:36Z

src/flamenco/gossip/fd_crds.c


-  /* value data ... */
+  /* Pool fields. Not in use when pool element is acquired */
+  ulong pool_next;


Suggested change

ulong pool_next;

struct {

ulong next;

} pool;

ulong num_duplicates;

mmcgee-jump · 2025-05-30T00:37:23Z

src/flamenco/gossip/fd_crds.c

-  lookup_map_t *    lookup_map;
+  evict_treap_t *          evict_treap;
+  staked_expire_dlist_t *  staked_expire_dlist;
+  unstaked_expire_dlist_t *unstaked_expire_dlist;


Suggested change

unstaked_expire_dlist_t *unstaked_expire_dlist;

unstaked_expire_dlist_t * unstaked_expire_dlist;

mmcgee-jump · 2025-05-30T00:39:26Z

src/flamenco/gossip/fd_crds.c

 fd_crds_acquire( fd_crds_t * crds ) {
-  if( FD_UNLIKELY( !crds_pool_free( crds->pool )==0UL ) ) {
-    evict_treap_fwd_iter_t head = evict_treap_fwd_iter_init( crds->evict_treap );
+  if( FD_UNLIKELY( crds_pool_free( crds->pool )==0UL ) ) {


Suggested change

if( FD_UNLIKELY( crds_pool_free( crds->pool )==0UL ) ) {

if( FD_UNLIKELY( !crds_pool_free( crds->pool ) ) ) {

mmcgee-jump · 2025-05-30T00:40:27Z

src/flamenco/gossip/fd_crds.c

-  if( FD_LIKELY( candidate->wallclock>value->wallclock ) ) return 1;
-  else if( FD_LIKELY( candidate->wallclock<value->wallclock ) ) return 0;
+  if( FD_UNLIKELY( cand_wc>val_wc ) ) return 1;
+  else if( FD_UNLIKELY( cand_wc<val_wc ) ) return 0;
  else return !!candidate->hash.hash<value->hash.hash;


Suggested change

else return !!candidate->hash.hash<value->hash.hash;

else return !!(candidate->hash.hash<value->hash.hash);

mmcgee-jump · 2025-05-30T00:41:34Z

src/flamenco/gossip/fd_crds.h

 FD_FN_CONST ulong
 fd_crds_align( void );

 FD_FN_CONST ulong
-fd_crds_footprint( ulong ele_max );
+fd_crds_footprint( ulong ele_max, ulong purged_max );


Suggested change

fd_crds_footprint( ulong ele_max, ulong purged_max );

fd_crds_footprint( ulong ele_max,

ulong purged_max );

src/flamenco/gossip/fd_crds.c

ravyu-jump added 4 commits May 16, 2025 07:33

setup type defs and fn defintions for parsing

b22d9d7

parsers for ping and pong

9841130

progress

dfafa9b

rx ping/pong, tx ping, ping/pong serializers, helper functions, coale…

df53f71

…sce ping and pong into one type

ravyu-jump changed the title ~~WIP: gossip2 branch~~ WIP: changes to merge gossip2 branch May 16, 2025

init keyguard_client

11a23ee