rework tower #6524

lidatong · 2025-09-26T20:22:41Z

No description provided.

github-actions · 2025-10-31T16:14:15Z

Performance Measurements ⏳

Suite	Baseline	New	Change
backtest `mainnet-368528500-perf` per slot	`0.07274 s`	`0.07278 s`	`0.055%` ✅
backtest `mainnet-368528500-perf` snapshot load	`2.669 s`	`2.678 s`	`0.337%` ✅
backtest `mainnet-368528500-perf` total elapsed	`72.74007 s`	`72.780064 s`	`0.055%` ✅
`firedancer mem` usage with `mainnet.toml`	`974.13 GiB`	`977.14 GiB`	`0.309%` ✅

github-actions · 2025-10-31T16:21:46Z

Performance Measurements ⏳

Suite	Baseline	New	Change
backtest `mainnet-368528500-perf` per slot	`0.060974 s`	`0.050784 s`	`-16.712%` ✅
backtest `mainnet-368528500-perf` snapshot load	`1.748 s`	`1.397 s`	`-20.080%` ✅
backtest `mainnet-368528500-perf` total elapsed	`60.974075 s`	`50.784036 s`	`-16.712%` ✅
`firedancer mem` usage with `mainnet.toml`	`974.13 GiB`	`977.14 GiB`	`0.309%` ✅

github-actions · 2025-10-31T16:32:37Z

Performance Measurements ⏳

Suite	Baseline	New	Change
backtest `mainnet-368528500-perf` per slot	`0.064268 s`	`0.063969 s`	`-0.465%` ✅
backtest `mainnet-368528500-perf` snapshot load	`2.202 s`	`2.147 s`	`-2.498%` ✅
backtest `mainnet-368528500-perf` total elapsed	`64.267761 s`	`63.968995 s`	`-0.465%` ✅
`firedancer mem` usage with `mainnet.toml`	`974.13 GiB`	`977.14 GiB`	`0.309%` ✅

github-actions · 2025-10-31T20:55:49Z

Performance Measurements ⏳

Suite	Baseline	New	Change
backtest `mainnet-368528500-perf` per slot	`0.052687 s`	`0.052813 s`	`0.239%` ✅
backtest `mainnet-368528500-perf` snapshot load	`1.681 s`	`1.654 s`	`-1.606%` ✅
backtest `mainnet-368528500-perf` total elapsed	`52.687353 s`	`52.813185 s`	`0.239%` ✅
`firedancer mem` usage with `mainnet.toml`	`974.13 GiB`	`977.14 GiB`	`0.309%` ✅

src/discof/tower/fd_tower_tile.h

src/discof/tower/fd_tower_tile.c

mmcgee-jump · 2025-11-11T18:08:49Z

src/choreo/tower/fd_tower_serde.c

+}
+
+int
+fd_compact_tower_sync_deserialize( fd_compact_tower_sync_serde_t * serde,


Can you write a fuzzer for deserializer

ill do in a follow-up PR

src/discof/tower/fd_tower_tile.c

github-actions · 2025-11-11T18:32:10Z

Performance Measurements ⏳

Suite	Baseline	New	Change
backtest `mainnet-368528500-perf` per slot	`0.07653 s`	`0.076481 s`	`-0.064%` ✅
backtest `mainnet-368528500-perf` snapshot load	`2.66 s`	`2.617 s`	`-1.617%` ✅
backtest `mainnet-368528500-perf` total elapsed	`76.529778 s`	`76.481128 s`	`-0.064%` ✅
`firedancer mem` usage with `mainnet.toml`	`992.14 GiB`	`995.14 GiB`	`0.302%` ✅

github-actions · 2025-11-12T00:19:27Z

Performance Measurements ⏳

Suite	Baseline	New	Change
backtest `mainnet-368528500-perf` per slot	`0.073372 s`	`0.073212 s`	`-0.218%` ✅
backtest `mainnet-368528500-perf` snapshot load	`2.635 s`	`2.659 s`	`0.911%` ✅
backtest `mainnet-368528500-perf` total elapsed	`73.37205 s`	`73.212229 s`	`-0.218%` ✅
`firedancer mem` usage with `mainnet.toml`	`992.14 GiB`	`995.14 GiB`	`0.302%` ✅

mmcgee-jump · 2025-11-12T17:36:39Z

src/app/firedancer/config/default.toml

+        # unrooted slots ahead of the current root.  Additionally, both
+        # fork choice and tower structures will OOM and cause Firedancer
+        # to exit if it needs to maintain more than max unrooted slots
+        # tower forks (TODO in the future Firedancer will instead


This is operator facing so don't leave TODOs unless they are immediate.

mmcgee-jump · 2025-11-12T17:42:47Z

src/app/firedancer/config/default.toml

+        # to exit if it needs to maintain more than max unrooted slots
+        # tower forks (TODO in the future Firedancer will instead
+        # gracefully degrade by evicting forks).
+        max_unrooted_slots = 4096


I still really don't buy that this limit needs to exist.

github-actions · 2025-11-12T18:43:27Z

Performance Measurements ⏳

Suite	Baseline	New	Change
backtest `mainnet-368528500-perf` per slot	`0.073126 s`	`0.073615 s`	`0.669%` ✅
backtest `mainnet-368528500-perf` snapshot load	`3.254 s`	`3.174 s`	`-2.459%` ✅
backtest `mainnet-368528500-perf` total elapsed	`73.125831 s`	`73.615013 s`	`0.669%` ✅
`firedancer mem` usage with `mainnet.toml`	`993.14 GiB`	`996.14 GiB`	`0.302%` ✅

github-actions · 2025-11-12T18:54:54Z

Performance Measurements ⏳

Suite	Baseline	New	Change
backtest `mainnet-368528500-perf` per slot	`0.073573 s`	`0.073803 s`	`0.313%` ✅
backtest `mainnet-368528500-perf` snapshot load	`3.207 s`	`3.087 s`	`-3.742%` ✅
backtest `mainnet-368528500-perf` total elapsed	`73.572773 s`	`73.8034 s`	`0.313%` ✅
`firedancer mem` usage with `mainnet.toml`	`993.14 GiB`	`996.14 GiB`	`0.302%` ✅

lidatong force-pushed the chali/feat/gossip-tower branch from ae8120e to 5edb185 Compare September 29, 2025 21:23

lidatong changed the title ~~feat(tower): integrate with gossip v2 and rework serdes~~ feat(choreo): rewrite for dup handling and gossip integratio Oct 9, 2025

lidatong changed the title ~~feat(choreo): rewrite for dup handling and gossip integratio~~ feat(choreo): rewrite for dup handling and gossip integration Oct 9, 2025

lidatong force-pushed the chali/feat/gossip-tower branch 2 times, most recently from 68eda9d to 1c4c55d Compare October 10, 2025 15:05

lidatong changed the title ~~feat(choreo): rewrite for dup handling and gossip integration~~ feat(choreo): dup handling, gossip int, bug fixes, missing logic Oct 17, 2025

lidatong force-pushed the chali/feat/gossip-tower branch 6 times, most recently from 9a7776a to 9b96afa Compare October 27, 2025 22:38

lidatong marked this pull request as ready for review October 27, 2025 22:39

lidatong requested a review from emwang-jump as a code owner October 27, 2025 22:39

lidatong force-pushed the chali/feat/gossip-tower branch 9 times, most recently from 5d6e10f to a8cfa82 Compare October 31, 2025 16:09

lidatong force-pushed the chali/feat/gossip-tower branch from a8cfa82 to cabd5d6 Compare October 31, 2025 16:18

lidatong force-pushed the chali/feat/gossip-tower branch from cabd5d6 to 6fba472 Compare October 31, 2025 16:28

lidatong force-pushed the chali/feat/gossip-tower branch from 6fba472 to 2424825 Compare October 31, 2025 20:51