[WIP] snapshots: restructure config options #6832
Draft
+457
−558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amass-jump
commented
Oct 21, 2025
| } shredcap; | ||
|
|
||
| struct { | ||
| struct fd_topo_tile_snapct { |
There was a problem hiding this comment.
Note: This change is so that I can copy this struct from the topo* in unprivliged_init to the tile's context. I don't see this pattern being done already, but it avoids having to define this struct a third time in the code (fd_config + fd_topo + snapct_ctx)
amass-jump
force-pushed
the
amass/snap-config
branch
4 times, most recently
from
4d11156 to
4341be7
Compare
amass-jump
force-pushed
the
amass/snap-config
branch
2 times, most recently
from
3f6b4f0 to
60ca0eb
Compare
amass-jump
commented
Oct 22, 2025
Comment on lines
+394
to
+397
| /* FD_ARRAY_CNT returns the number of elements of the given array. */ | ||
|
|
||
| #define FD_ARRAY_CNT(x) (sizeof(x)/sizeof((x)[0])) | ||
|
|
amass-jump
force-pushed
the
amass/snap-config
branch
from
60ca0eb to
9cd41c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.