Assemble: use tensor kwarg in FormSum maxpy #4056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrubeck
force-pushed
the
pbrubeck/fix/base-form-tensor
branch
from
dfec145 to
a5b09af
Compare
|
|
pbrubeck
commented
Feb 20, 2025
pbrubeck
commented
Feb 20, 2025
pbrubeck
commented
Feb 20, 2025
pbrubeck
commented
Feb 20, 2025
pbrubeck
commented
Feb 20, 2025
pbrubeck
commented
Feb 20, 2025
pbrubeck
commented
Feb 20, 2025
pbrubeck
commented
Feb 20, 2025
pbrubeck
commented
Feb 20, 2025
pbrubeck
commented
Feb 21, 2025
dham
reviewed
Feb 26, 2025
Contributor
|
Just noticed that this fixes #3212 so I have amended the PR description to make sure it gets closed. |
|
pbrubeck
force-pushed
the
pbrubeck/fix/base-form-tensor
branch
from
b815048 to
179fe50
Compare
pbrubeck
commented
Mar 13, 2025
dham
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Assembling a linear combination of
BaseForms, (i.e. aFormSumofScalars,Cofunctions, orMatrices) was always allocating a new tensor for the result, ignoring thetensorkwarg. This PR fixes this.Here we unify some basic functionality of the data carrier classes for 0-forms (
Constant/ R-spaceCofunction), linear forms (Cofunction), and bilinear form (MatrixBase) by implementing theMatrixBase.zero()andMatrixBase.assign().Fixes #3212