Draft
Conversation
…transforms for the simplex refinement
This is necessary because the previous approach to generating periodic meshes resulted in a DMPlex with a slightly invalid state that prevents subsequent transformations (in particular extrusion). We also avoid manually labelling the boundaries in favour of just renumbering the existing 'Face Sets' label produced by the DMPlex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
DMPlex.createBoxMeshto generate our periodic meshes. This is needed because the current approach that we use results in an invalid DMPlex that cannot subsequently be extruded. This PR is therefore a blocker for pyop3."crossed","left"or"right"refinement instead of rolling our own solution.PartiallyPeriodicRectangleMesh. It's functionality is totally covered byPeriodicRectangleMesh.Breaking API changes
Prerequisite PRs