-
Notifications
You must be signed in to change notification settings - Fork 179
Change test_extrusion_lsw python demo to rst demo #4852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change test_extrusion_lsw python demo to rst demo #4852
Conversation
connorjward
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Please also add this to the docs here. Before merging we'll also need to check that this renders correctly on the website. You can do this in the Docker container by going to firedrake_repo/docs and running make html.
|
Unfortunately this is not passing tests: Looking at the RST file there appears to be inconsistent indentation for the Python snippets. |
connorjward
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work. Thanks so much! I will merge if tests pass.
Co-authored-by: Josh Hope-Collins <jhc.jss@gmail.com>
|
All done. Thank you! |
Description
Fixes #3864