Skip to content

Conversation

@ZiyaSelim
Copy link
Contributor

@ZiyaSelim ZiyaSelim commented Jan 31, 2026

Description

Fixes #3864

@ZiyaSelim ZiyaSelim changed the title Demo python to rst Change test_extrusion_lsw python demo to rst demo Jan 31, 2026
Copy link
Contributor

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Please also add this to the docs here. Before merging we'll also need to check that this renders correctly on the website. You can do this in the Docker container by going to firedrake_repo/docs and running make html.

@connorjward
Copy link
Contributor

Unfortunately this is not passing tests:

1	FAILED firedrake-repo/tests/firedrake/demos/test_demos_run.py::test_serial_demo[extruded_shallow_water/extruded_shallow_water] -   File "/tmp/pytest-of-root/pytest-25/popen-gw0/test_serial_demo_extruded_shal0/extruded_shallow_water.py", line 21
1	    power = 5
1	IndentationError: unexpected indent

Looking at the RST file there appears to be inconsistent indentation for the Python snippets.

connorjward
connorjward previously approved these changes Feb 6, 2026
Copy link
Contributor

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. Thanks so much! I will merge if tests pass.

Co-authored-by: Josh Hope-Collins <jhc.jss@gmail.com>
@connorjward connorjward merged commit 2aee5bb into firedrakeproject:main Feb 10, 2026
7 checks passed
@connorjward
Copy link
Contributor

All done. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: extruded_shallow_water demo is not tested

3 participants