Automate docs element list for interpolation#4854
Draft
leo-collins wants to merge 2 commits intomainfrom
Draft
Conversation
pbrubeck
reviewed
Feb 2, 2026
| ufl_elem = FiniteElement(family, cell=cell, degree=degree_range[0]) | ||
| finat_element = create_element(ufl_elem) | ||
|
|
||
| if short_name in {"BDMCF", "BDMCE"}: |
Contributor
There was a problem hiding this comment.
What error is thrown here?
Contributor
Author
There was a problem hiding this comment.
Traceback (most recent call last):
File "/Users/lac224/Coding/work/firedrake-dev/firedrake/docs/source/element_list.py", line 51, in <module>
finat_element.dual_basis
File "/Users/lac224/Coding/work/firedrake-dev/fiat/finat/fiat_elements.py", line 245, in dual_basis
Q, pts = self._dual_basis
^^^^^^^^^^^^^^^^
File "/opt/homebrew/Cellar/python@3.13/3.13.9/Frameworks/Python.framework/Versions/3.13/lib/python3.13/functools.py", line 1026, in __get__
val = self.func(instance)
File "/Users/lac224/Coding/work/firedrake-dev/fiat/finat/fiat_elements.py", line 158, in _dual_basis
fiat_dual_basis = self._element.dual_basis()
File "/Users/lac224/Coding/work/firedrake-dev/fiat/FIAT/finite_element.py", line 63, in dual_basis
return self.dual.get_nodes()
^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'get_nodes'
Contributor
There was a problem hiding this comment.
Okay, easy. We just need to redo this PR for these elements
firedrakeproject/fiat#182
Contributor
There was a problem hiding this comment.
Could you confirm that BDMC fails as expected after checking out this FIAT branch, firedrakeproject/fiat#218?
pbrubeck
reviewed
Feb 5, 2026
|
|
||
| Firedrake supports the use of the following finite elements. | ||
| Firedrake supports the use of the following finite elements. The last column | ||
| specifies if we support interpolation **into** a function space built from the element. |
Contributor
There was a problem hiding this comment.
We should say that interpolation from is universally supported
pbrubeck
reviewed
Feb 5, 2026
| .. csv-table:: | ||
| :header: "Name", "Short name", "Value shape", "Valid cells" | ||
| :widths: 20, 10, 10, 40 | ||
| :header: "Name", "Short name", "Value shape", "Valid cells", "Supports interpolation?" |
Contributor
There was a problem hiding this comment.
The column name could be more specific. Maybe "Valid interpolation target"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires firedrakeproject/fiat#216