Repository navigation
Delete shared default options after context #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pbrubeck
wants to merge
14
commits into
main
Choose a base branch
from
pbrubeck/delete-default-options
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
0f94d5b
Delete the options inherited through default_options_set
pbrubeck 90c7bbc
Delete inherited child options after context
pbrubeck 03e58ed
Restore option cleanup comments
pbrubeck 997a0a7
Address shared default options review
pbrubeck 78b35e5
Restore pre-PR option comments
pbrubeck b58aed5
Clarify shared default cleanup comment
pbrubeck 2940ce0
Preserve existing child options on context exit
pbrubeck 79055e5
Update petsctools/options.py
pbrubeck 242c815
Update petsctools/options.py
pbrubeck 965a564
Update petsctools/options.py
pbrubeck 9c9937b
Update petsctools/options.py
pbrubeck 6007fc4
Update petsctools/options.py
pbrubeck 916517d
Update petsctools/options.py
pbrubeck a1e5081
combine tests
pbrubeck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please can you test:
parent_0andparent_1), and callinginserted_optionson both in turn (not nested).-parent_ksp_type cg -parent_1_ksp_type gmres