Skip to content

Conversation

@rjsheperd
Copy link
Contributor

Purpose

Creates a new Safe Separation Distance Calculator. Please be sure to review the accompanying C++ changes here: firelab/behave#55

Related Issues

Closes BHP1-1247

Submission Checklist

  • Included Jira issue in the PR title (e.g. BHP1-### <title>)
  • Code passes linter rules (clj-kondo --lint components/**/src bases/**/src projects/**/src)
  • Feature(s) work when compiled (clojure -M:compile-cljs)

Testing

  1. Start VMS, run migration migrations.2025-08-03-add-safe-separation-distance-calculator
  2. Start App, sync
  3. Open "Calculators" -> "Safe Separation Distance"
  4. Run with:
  • "High/Extreme" values in the drop downs
  • Vegetation Height: 5 ft
  1. Verify that the Safety Condition shows "Extreme" with a red background
  2. Run with:
  • "Moderate" values in the drop downs
  • Vegetation Height: 5 ft
  1. Verify that the Safety Condition shows "Moderate" with a yellow background

@rjsheperd rjsheperd changed the base branch from main to rj-BHP1-1290-relative-humidity-tool August 27, 2025 15:08
@Kcheung42
Copy link
Collaborator

Kcheung42 commented Aug 27, 2025

Noticing that changing the units don't recalculate the outputs

@rjsheperd
Copy link
Contributor Author

@Kcheung42 that's only for auto-computing tools. This isn't set up that way. We'll be looking at adding the global Metric/English switch to make this more straightforward.

@rjsheperd rjsheperd changed the base branch from rj-BHP1-1290-relative-humidity-tool to main August 27, 2025 17:00
@Kcheung42
Copy link
Collaborator

Kcheung42 commented Aug 27, 2025

Ah right. Looks good then! One thing to note during migration: Be sure to re evaluate conn in between the transactions (tx-data-1, tx-data2 etc), otherwise i ran into an error of missing entities (i.e. ln 92 (sm/t-key->eid conn "behaveplus:tags:safety-conditions")) and the transaction would silently fail.

@rjsheperd rjsheperd merged commit 82d6ccc into main Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants