-
Notifications
You must be signed in to change notification settings - Fork 46
refactor(cSDK): Mandatory configuration.json in configuration_form example #616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
90691a2
eb52a6b
6c80bea
2713980
fa64d5a
5a0313f
9030569
74c119e
38831a2
3c056a3
8eedc2e
f81673b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When users run this example from a fresh checkout with the newly provided Useful? React with 👍 / 👎. |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-satvikpatil Can we update readme for this?
Currently it says this :
The API fields (api_base_url, api_key) in the configuration form illustrate how a real connector would collect connection details. The configuration.json file provided contains sample values for running the connector locally.