[Bug Fix] Add unique key from source package and update tests - #28
Open
fivetran-reneeli wants to merge 6 commits into
Open
[Bug Fix] Add unique key from source package and update tests#28fivetran-reneeli wants to merge 6 commits into
fivetran-reneeli wants to merge 6 commits into
Conversation
9 tasks
fivetran-joemarkiewicz
approved these changes
Jan 24, 2022
fivetran-joemarkiewicz
left a comment
fivetran-joemarkiewicz
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Only thing we need to add before we merge is an update to the CHANGELOG and switching the dependency once the source is live!
Comment on lines
+2
to
+3
| # - package: fivetran/mailchimp_source | ||
| # version: [">=0.3.0", "<0.4.0"] |
Contributor
There was a problem hiding this comment.
Obligatory reminder to update this before we merge 😄
fivetran-joemarkiewicz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Are you a current Fivetran customer?
What change(s) does this PR introduce?
Does this PR introduce a breaking change?
Yes (please provide breaking change details below.)
No (please provide explanation how the change is non breaking below.)
new fields; may be used in place of other fields used in previous joins
Is this PR in response to a previously created Issue
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
💃
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.