Feature/union data - #57
Merged
Merged
Conversation
…vetran/dbt_mailchimp into feature/union-data-GA-1007462 merge
|
|
||
| ## Tests Update | ||
| - Removes uniqueness tests. The new unioning feature requires combination-of-column tests to consider the new `source_relation` column in addition to the existing primary key, but this is not supported across dbt versions. | ||
| - These tests will be reintroduced once a version-agnostic solution is available. |
Contributor
There was a problem hiding this comment.
Add a bullet here clarifying that uniqueness tests were left in place for surrogate keys where the source_relation field was added. Looks like there are two still here.
Contributor
Author
There was a problem hiding this comment.
Good call. Added!
fivetran-savage
approved these changes
Nov 7, 2025
…vetran/dbt_mailchimp into feature/union-data-GA-1007462 merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
Summary of changes:
Submission Checklist
Changelog