Skip to content

Feature/union data - #57

Merged
fivetran-catfritz merged 14 commits into
mainfrom
feature/union-data-GA-1007462
Nov 7, 2025
Merged

Feature/union data#57
fivetran-catfritz merged 14 commits into
mainfrom
feature/union-data-GA-1007462

Conversation

@fivetran-catfritz

@fivetran-catfritz fivetran-catfritz commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

PR Overview

Package version introduced in this PR:

  • v1.1.0

This PR addresses the following Issue/Feature(s):

  • GA-1007462

Summary of changes:

  • Add union data feature.

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
    • Testing Instructions: Confirm the change addresses the issue(s)
    • Focus Areas: Complex logic or queries that need extra attention
  • Merge any relevant open PRs into this PR

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@fivetran-catfritz fivetran-catfritz self-assigned this Nov 5, 2025
@fivetran-catfritz fivetran-catfritz changed the title Feature/union data ga 1007462 Feature/union data Nov 6, 2025
@fivetran-catfritz fivetran-catfritz added the docs:ready Triggers the docs generator workflow. label Nov 6, 2025
Comment thread CHANGELOG.md Outdated

## Tests Update
- Removes uniqueness tests. The new unioning feature requires combination-of-column tests to consider the new `source_relation` column in addition to the existing primary key, but this is not supported across dbt versions.
- These tests will be reintroduced once a version-agnostic solution is available.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a bullet here clarifying that uniqueness tests were left in place for surrogate keys where the source_relation field was added. Looks like there are two still here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. Added!

@fivetran-catfritz fivetran-catfritz added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Nov 7, 2025
@fivetran-catfritz
fivetran-catfritz merged commit 6ec73c9 into main Nov 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs:ready Triggers the docs generator workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants