[MAINTENANCE] Drop the gx-redshift CI marker - #12060
Merged
Merged
Conversation
✅ Deploy Preview for niobium-lead-7998 canceled.
|
joshua-stauffer
marked this pull request as ready for review
August 13, 2026 09:26
`gx-redshift` was a CI-launch key rather than a pytest marker: it selected a requirements file that installed the forked dialect, and a marker-string translation mapped it back to `redshift` so the right tests ran. It was never registered as a marker, which is why it needed an exemption from the check that every dependency-map key is a real one. Both requirements files now install the same upstream dialect and the lane selects `redshift` directly, so the key selects nothing the canonical marker does not already select, and the translation and the exemption have nothing left to describe. The deprecated `gx-redshift` *extra* is unaffected. It is a separate surface, built from the requirements file directly by setup.py, and remains supported so existing install commands keep working. Sequenced after the lane rename rather than alongside it: workflow definitions come from the base branch, so a pull request that removes this key while the base branch still selects it would install no Redshift dependencies and select no tests, passing the lane's own invocation while running nothing.
joshua-stauffer
force-pushed
the
m/drop-gx-redshift-marker
branch
from
August 13, 2026 09:28
ee38d42 to
2957e2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #12044, now merged — this branch is rebased onto
developand contains a single commit.What
Removes the
gx-redshiftCI-launch key:MARKER_DEPENDENCY_MAP["gx-redshift"]intasks.pygx-redshift→'redshift'translation in_marker_statementNO_TEST_MARKERSexemption intests/test_markers.pyWhy
gx-redshiftwas never a pytest marker — it was a CI-launch key that selected the requirements file installing the forked dialect, with a marker-string translation mapping it back toredshiftso the right tests ran. That is also why it needed an exemption from the check that every dependency-map key is a registered marker.Now that both requirements files install the same upstream dialect and the lane selects
redshiftdirectly (#12044), the key selects nothing the canonical marker does not already select.The deprecated
gx-redshiftextra is unaffected — it is built from the requirements file directly bysetup.pyand remains supported, so existing install commands keep working.Why this was split from #12044
Workflow definitions come from the base branch. Removing this key while
developstill selectedgx-redshiftwould have installed no Redshift dependencies (the lookup is a silent.get) and selected no tests — the lane would have run nothing while appearing to run, andredshiftis in the CI-results gate'sneeds:.With #12044 merged,
develop's lane now invokesinvoke ci-tests 'redshift', which resolves against this branch to marker statement'redshift'and dependency entryreqs/requirements-dev-redshift.txt. The Redshift lane keeps working continuously across both merges.Verification
tests/test_markers.py,tests/test_sql_backend_wiring.py,tests/test_packaging.py— 69 passed, 7 skipped against the rebased base.ruff checkandruff format --checkclean.