Only test the first element of status #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When using webmock, the `"OK"` String is not present in `StringIO#status`.
postmodern
added a commit
to postmodern/spidr
that referenced
this pull request
Aug 5, 2016
* Set a User-Agent to prevent open-uri from raising an exception about being passed a nil User-Agent. * Found a bug in how webmock returns the HTTP status message, which tripped up the robots gem. * bblimke/webmock#642 * fizx/robots#9
|
And in Webrick, for some reasons, the "OK" is actually "OK " (trailing space). So I think it's better not to rely on that "OK" to be always properly formatted or there at all. |
juliend2
pushed a commit
to statusmachine/robots
that referenced
this pull request
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"OK"String is not present inStringIO#status.