Skip to content

fix: harden release status checks #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flamerged merged 2 commits into from
May 14, 2026
Merged

fix: harden release status checks #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f583215
fix: harden release status checks
flamerged May 14, 2026
e6d1968
fix: handle stale release-check locks
flamerged May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions bin/menutube.5s.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ release_tag_norm() {
latest_release_tag_from_asset_url() {
local tag
tag="$(printf '%s' "$MENUTUBE_RELEASE_ASSET_URL" | /usr/bin/sed -n 's#.*releases/download/\([^/]*\)/.*#\1#p' | head -1)"
[[ -n "$tag" ]] || return 1
[[ -n "$tag" && "$tag" != "latest" ]] || return 1
printf '%s' "$tag"
}

Expand Down Expand Up @@ -318,18 +318,23 @@ release_check_cache_age() {
maybe_refresh_release_check() {
truthy "$MENUTUBE_CHECK_RELEASE_UPDATES" || return
[[ "$MENUTUBE_RELEASE_CHECK_TTL_SECONDS" == <-> ]] || MENUTUBE_RELEASE_CHECK_TTL_SECONDS=86400
local age now lock_age
local age lock_file lock_mtime current_mtime now lock_age
age="$(release_check_cache_age)"
if [[ -n "$age" && "$age" -le "$MENUTUBE_RELEASE_CHECK_TTL_SECONDS" ]]; then
return
fi
now="$(date +%s 2>/dev/null || printf '0')"
lock_age="$(cache_mtime "${MENUTUBE_RELEASE_CHECK_CACHE}.lock")"
if [[ -n "$lock_age" && $(( now - lock_age )) -lt 120 ]]; then
return
fi
mkdir -p "${MENUTUBE_RELEASE_CHECK_CACHE:h}" 2>/dev/null || return
: > "${MENUTUBE_RELEASE_CHECK_CACHE}.lock" 2>/dev/null || return
lock_file="${MENUTUBE_RELEASE_CHECK_CACHE}.lock"
lock_mtime="$(cache_mtime "$lock_file")"
if [[ -n "$lock_mtime" ]]; then
now="$(date +%s 2>/dev/null || printf '0')"
lock_age=$(( now - lock_mtime ))
if [[ "$lock_age" -gt 300 ]]; then
current_mtime="$(cache_mtime "$lock_file")"
[[ "$current_mtime" == "$lock_mtime" ]] && rm -f "$lock_file" 2>/dev/null || true
fi
fi
( set -C; : > "$lock_file" ) 2>/dev/null || return
"$SCRIPT" check-release >/dev/null 2>&1 &
}

Expand Down
Loading