Adding field in Admin Configuration to show current IP#21
Open
akkaweb wants to merge 1 commit intoflancer32:masterfrom
Open
Adding field in Admin Configuration to show current IP#21akkaweb wants to merge 1 commit intoflancer32:masterfrom
akkaweb wants to merge 1 commit intoflancer32:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow developers working on sites behind VPNs where IP might not be so obvious to show the actual IP that Magento sees from the developer.
For me I actually created an extension of this module allowing this override. However, I will remove the module once this is reviewed, approved and released.
I could not use this module because I was behind VPN on many sites I work on and the IP sometimes changes.