Skip to content

Conversation

avalonche
Copy link
Collaborator

@avalonche avalonche commented Sep 30, 2025

πŸ“ Summary

flashtestation contracts have updated, need to refactor the registration call to reflect that.

πŸ’‘ Motivation and Context


βœ… I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

@avalonche avalonche force-pushed the updated-registration branch from 9a8875b to 79aff67 Compare October 1, 2025 16:19
@avalonche avalonche force-pushed the flashblocks-integration-tests branch from bea9247 to 201311d Compare October 2, 2025 05:44
@avalonche avalonche force-pushed the updated-registration branch from 79aff67 to 0b9b3a3 Compare October 2, 2025 05:44
.map_err(|err| BuilderTransactionError::EvmExecutionError(Box::new(err)))?;

evm.db_mut().commit(state);
evm.db_mut().merge_transitions(BundleRetention::Reverts);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was it doing there?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

evm.db_mut().merge_transitions(BundleRetention::Reverts); was used to record points to revert the simulation state to a previous state. But we changed the implementation to just recreate a new state for every simulation run

let tee_address_bytes: [u8; 20] = tee_service_signer.address.into();

// Calculate keccak256 hash of empty bytes (32 bytes)
let ext_data = Bytes::from(b"");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i saw this code already
was it reverted before? Or copy?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breakout from #268

@avalonche avalonche force-pushed the updated-registration branch from 0b9b3a3 to 581ebac Compare October 2, 2025 17:47
Base automatically changed from flashblocks-integration-tests to main October 3, 2025 17:40
@avalonche avalonche force-pushed the updated-registration branch from 581ebac to 8768d27 Compare October 3, 2025 17:47
@avalonche avalonche merged commit ccdd1b1 into main Oct 3, 2025
3 of 4 checks passed
@avalonche avalonche deleted the updated-registration branch October 3, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants