feat: implement max/min req/res sizes #10
Conversation
we need to prepare for implementation of FCUs deduplication (this avalanche problem still persists). that will require assembly of incoming requests before the decision whether to proxy them or not is made => and for that we will need buffers + reasonable limits.
|
|
||
| let bck_req = this.backend.new_backend_request(&info); | ||
| let bck_req_body = ProxyHttpRequestBody::new(this.clone(), info, cli_req_body, timestamp); | ||
| let bck_req_body = ProxyHttpRequestBody::new( |
There was a problem hiding this comment.
wdyt about using full name?
i could read this as:
block_req_body
backend_req_body
There was a problem hiding this comment.
renamed:
bck=>bkndcli=>clnt
There was a problem hiding this comment.
What do these shortenings add? It's more straightforward to use full names for these sorts of variables
There was a problem hiding this comment.
they make it easier for me to see more code on a single screen of my laptop.
rust is extremely verbose language, especially with autoformatting rules applied.
| if let Some(info) = mem::take(this.info) { | ||
| warn!( | ||
| proxy = P::name(), | ||
| request_id = %info.id(), |
There was a problem hiding this comment.
Did you mean to include connection id here too or was not including it intentional? I don't understand why you need to repeat this code instead of defining a function or something
There was a problem hiding this comment.
yes, I did mean to include it. just overlooked it. thanks for pointing out
There was a problem hiding this comment.
re. function: maybe some day that will happen. I don't want to optimise things prematurely. once the code stabilised we can think about it
| if let Some(info) = mem::take(this.info) { | ||
| warn!( | ||
| proxy = P::name(), | ||
| request_id = %info.id(), |
There was a problem hiding this comment.
yes, I did mean to include it. just overlooked it. thanks for pointing out
| if let Some(info) = mem::take(this.info) { | ||
| warn!( | ||
| proxy = P::name(), | ||
| request_id = %info.id(), |
There was a problem hiding this comment.
re. function: maybe some day that will happen. I don't want to optimise things prematurely. once the code stabilised we can think about it
|
|
||
| let bck_req = this.backend.new_backend_request(&info); | ||
| let bck_req_body = ProxyHttpRequestBody::new(this.clone(), info, cli_req_body, timestamp); | ||
| let bck_req_body = ProxyHttpRequestBody::new( |
There was a problem hiding this comment.
renamed:
bck=>bkndcli=>clnt
3 participants
we need to prepare for implementation of FCUs deduplication (this avalanche problem still persists).
that will require assembly of incoming requests before the decision whether to proxy them or not is made => and for that we will need buffers + reasonable limits.