-
Notifications
You must be signed in to change notification settings - Fork 541
Bump tvm ffi version #1939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump tvm ffi version #1939
Conversation
<!-- .github/pull_request_template.md --> ## 📌 Description This PR fixes the dev container after flashinfer-ai#1880. <!-- What does this PR do? Briefly describe the changes and why they’re needed. --> ## 🔍 Related Issues <!-- Link any related issues here --> ## 🚀 Pull Request Checklist Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete. ### ✅ Pre-commit Checks - [ ] I have installed `pre-commit` by running `pip install pre-commit` (or used your preferred method). - [ ] I have installed the hooks with `pre-commit install`. - [ ] I have run the hooks manually with `pre-commit run --all-files` and fixed any reported issues. > If you are unsure about how to set up `pre-commit`, see [the pre-commit documentation](https://pre-commit.com/). ## 🧪 Tests - [ ] Tests have been added or updated as needed. - [ ] All tests are passing (`unittest`, etc.). ## Reviewer Notes <!-- Optional: anything you'd like reviewers to focus on, concerns, etc. -->
Summary of ChangesHello @cyx-6, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on adapting the FlashInfer codebase to a newer version of the Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request primarily bumps the tvm-ffi version and updates the codebase to align with the new API. The changes are mostly mechanical, such as replacing -> with . for member access and updating method calls like shape to size and data to data_ptr(). The changes are largely correct and consistent. However, I've identified one critical issue in csrc/xqa/utils.cuh where a change was incorrectly applied to a custom struct, which will likely cause a compilation failure. Please see the specific comment for details.
|
Let's defer it till the stable release of tvm-ffi |
|
@cyx-6 would you mind bumping to v0.1.0 stable release? |
|
Caution Review failedFailed to post review comments Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughA large-scale refactor updates tensor access patterns across CUDA and Python code from pointer-based field syntax (→data, →shape) to modern accessor methods (data_ptr(), size()). Additionally, apache-tvm-ffi dependency constraint is relaxed from fixed pre-release (0.1.0b15) to flexible version range (≥0.1, <0.2). Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Rationale: While the diff touches 70+ files, the changes are highly repetitive and follow consistent patterns: systematic replacement of pointer-based tensor access ( Poem
Pre-merge checks and finishing touches❌ Failed checks (3 warnings)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
|
closed for #1960 |
<!-- .github/pull_request_template.md --> ## 📌 Description This PR bumps the tvm-ffi to stable version 0.1.0 and update the flashinfer code base. <!-- What does this PR do? Briefly describe the changes and why they’re needed. --> ## 🔍 Related Issues #1939 ## 🚀 Pull Request Checklist Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete. ### ✅ Pre-commit Checks - [ ] I have installed `pre-commit` by running `pip install pre-commit` (or used your preferred method). - [ ] I have installed the hooks with `pre-commit install`. - [ ] I have run the hooks manually with `pre-commit run --all-files` and fixed any reported issues. > If you are unsure about how to set up `pre-commit`, see [the pre-commit documentation](https://pre-commit.com/). ## 🧪 Tests - [ ] Tests have been added or updated as needed. - [ ] All tests are passing (`unittest`, etc.). ## Reviewer Notes <!-- Optional: anything you'd like reviewers to focus on, concerns, etc. --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Relaxed build dependency pins for apache-tvm-ffi and setuptools across project configs; removed installation of multiple build packages from the nightly CI step. * **Refactor** * Modernized internal CUDA/tensor access patterns to a consistent accessor API across many modules. * **Bug Fixes** * GEMM runner now returns the output tensor in the correct (non‑transposed) orientation. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Zihao Ye <[email protected]> Co-authored-by: yzh119 <[email protected]>
📌 Description
This PR bumps the tvm-ffi version and update the flashinfer code base.
🔍 Related Issues
🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.
✅ Pre-commit Checks
pre-commitby runningpip install pre-commit(or used your preferred method).pre-commit install.pre-commit run --all-filesand fixed any reported issues.🧪 Tests
unittest, etc.).Reviewer Notes
Summary by CodeRabbit
Bug Fixes
Chores