chore: Update CODEOWNERS #1949
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,41 +3,41 @@ | |
| # Analysis period: 180 days | ||
| # Minimum commits threshold: 1 | ||
|
|
||
| benchmarks/ @bkryu @cyx-6 @nv-yunzheq @kahyunnam @jiahanc | ||
| benchmarks/routines/ @bkryu @nv-yunzheq @cyx-6 @nvmbreughe @Anerudhan | ||
| ci/ @cyx-6 @yzh119 @nvmbreughe | ||
| ci/scripts/ @cyx-6 | ||
| ci/scripts/jenkins/ @cyx-6 | ||
| csrc/ @wenscarl @yzh119 @cyx-6 @djmmoss @yongwww | ||
| csrc/fused_moe/ @yzh119 @yongwww @djmmoss @wenscarl @cyx-6 | ||
| csrc/fused_moe/cutlass_backend/ @yzh119 @yongwww @djmmoss @wenscarl @cyx-6 | ||
| csrc/nv_internal/ @wenscarl @djmmoss @yzh119 @cyx-6 @yongwww | ||
| csrc/nv_internal/cpp/ @wenscarl @yongwww @djmmoss @joker-eph @ttyio | ||
| csrc/nv_internal/include/ @wenscarl | ||
| csrc/nv_internal/tensorrt_llm/ @wenscarl @djmmoss @yzh119 @cyx-6 @yongwww | ||
| csrc/xqa/ @yzh119 @cyx-6 | ||
| docs/ @yzh119 @cyx-6 @wenscarl @nv-yunzheq @aleozlx | ||
| flashinfer/ @yzh119 @cyx-6 @wenscarl @nvmbreughe @bkryu | ||
| flashinfer-cubin/ @yzh119 @cyx-6 | ||
| flashinfer-cubin/flashinfer_cubin/ @yzh119 | ||
| flashinfer-jit-cache/ @yzh119 @cyx-6 | ||
| flashinfer-jit-cache/flashinfer_jit_cache/ @yzh119 | ||
| flashinfer/comm/ @yzh119 @cyx-6 @nvmbreughe @wenscarl @djmmoss | ||
| flashinfer/cudnn/ @Anerudhan @yzh119 @cyx-6 @Anerudhan | ||
| flashinfer/cute_dsl/ @yzh119 @kaixih @Amir-19 @aleozlx | ||
| flashinfer/fused_moe/ @djmmoss @yzh119 @cyx-6 @wenscarl @IwakuraRein | ||
| flashinfer/jit/ @yzh119 @cyx-6 @djmmoss @aleozlx @yongwww | ||
| flashinfer/jit/attention/ @yzh119 @Anerudhan @joker-eph | ||
| flashinfer/jit/gemm/ @yzh119 | ||
| flashinfer/logits_processor/ @cyx-6 @yzh119 | ||
| flashinfer/profiler/ @cyx-6 | ||
| flashinfer/triton/ @cyx-6 @nvmbreughe @yzh119 | ||
| flashinfer/tuning_configs/ @kaixih | ||
| include/ @yzh119 @cyx-6 @wenscarl @kahyunnam @joker-eph | ||
| include/flashinfer/ @yzh119 @cyx-6 @wenscarl @kahyunnam @joker-eph | ||
| include/flashinfer/attention/ @yzh119 @kahyunnam @joker-eph | ||
| include/flashinfer/comm/ @yongwww @nvmbreughe @djmmoss @yzh119 @cyx-6 | ||
| include/flashinfer/gemm/ @ttyio @yongwww @aleozlx @cyx-6 | ||
| include/flashinfer/trtllm/ @joker-eph @aleozlx @yzh119 @cyx-6 @wenscarl | ||
| profiler/ @cyx-6 | ||
| scripts/ @yzh119 @nvmbreughe @dierksen @yongwww @bkryu | ||
|
There was a problem hiding this comment. 🧩 Analysis chainCODEOWNERS update for The reordering of owners on line 43 reflects the commit activity analysis (frequency, coverage, and recency) from the 180-day git history window, which is the expected behavior from the automated workflow. All five owners remain assigned; only their sequence has changed based on contribution metrics. If you'd like, you can verify that the new owner order aligns with actual commit contributions by inspecting the git history: 🏁 Script executed: #!/bin/bash
# Description: Verify commit frequency for each owner in the scripts/ directory over the last 180 days
DAYS=180
DATE_SINCE=$(date -d "$DAYS days ago" +%Y-%m-%d)
echo "Commit frequency by author in scripts/ over the last $DAYS days (since $DATE_SINCE):"
git log --since="$DATE_SINCE" --pretty=format:"%an" -- scripts/ | sort | uniq -c | sort -rnLength of output: 301 CODEOWNERS ordering for The git log shows @yongwww with 5 commits and @dierksen with 2 commits over the past 180 days. The current line has @dierksen (position 3) ranked higher than @yongwww (position 4), which contradicts the stated contribution metrics. Expected order: Swap positions 3 and 4 to align with commit frequency. 🤖 Prompt for AI Agents |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this line has been updated correctly by the automation, the script that generates the
CODEOWNERSfile (scripts/codeowner_analyzer.py) appears to have a bug that can lead to duplicate entries. For instance, line 41 in this file lists@aleozlxtwice.This likely occurs because the generation script does not deduplicate the list of owners, which can happen if a single person contributes with multiple emails that resolve to the same GitHub username.
To prevent this in the future, the script should be updated to ensure the list of owners for any given path is unique. Using a
setto collect the usernames before joining them into a string would be an effective solution.