-
Notifications
You must be signed in to change notification settings - Fork 574
Port TRT-LLM communication kernels to flashinfer #2102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
e5b5e5d to
5fb452d
Compare
c0d0c04 to
2bac65a
Compare
710a388 to
bd82a2b
Compare
|
|
||
| # Initialize MNNVL memory system | ||
| MnnvlMemory.initialize() | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1245 adds an optional custom communicator for the MnnvlMemory initialization. This is necessary because sglang/vllm don't use MPI so the previous bootstrapping wouldn't work. We will need to allow users to pass through the custom communicator here as well.
- Can you add an arg to this function
config: Optional[MnnvlConfig] = None
- Then after MnnvlMemory.initialize(), add
if config:
MnnvlMemory.set_comm_from_config(mapping, config) # type: ignore[attr-defined]
I think that should take care of it. Thanks!
📌 Description
This ports the latest MNNVL A2A communication implementation from TRT-LLM
🔍 Related Issues
#2094
🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.
✅ Pre-commit Checks
pre-commitby runningpip install pre-commit(or used your preferred method).pre-commit install.pre-commit run --all-filesand fixed any reported issues.🧪 Tests
unittest, etc.).Reviewer Notes