Go modules, dependencies updates and Kubernetes 1.17 fixes #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Stefan Betermieux Signed-off-by: Mateusz Gozdek <[email protected]>
Signed-off-by: Mateusz Gozdek <[email protected]>
Otherwise following error message shows up:
E0113 15:13:54.428981 1 event.go:319] Could not construct reference to: '&v1.ConfigMap{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:"flatcar-linux-update-operator-lock", GenerateName:"", Namespace:"reboot-coordinator", SelfLink:"/api/v1/namespaces/reboot-coordinator/configmaps/flatcar-linux-update-operator-lock", UID:"b55a0fb9-03a9-4091-9a3c-bf84b8f8df6f", ResourceVersion:"2972", Generation:0, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:63714524547, loc:(*time.Location)(0x1e1af00)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string{"control-plane.alpha.kubernetes.io/leader":"{\"holderIdentity\":\"flatcar-linux-update-operator-85bd87b458-pfhhx\",\"leaseDurationSeconds\":90,\"acquireTime\":\"2020-01-13T15:13:54Z\",\"renewTime\":\"2020-01-13T15:13:54Z\",\"leaderTransitions\":1}"}, OwnerReferences:[]v1.OwnerReference(nil), Finalizers:[]string(nil), ClusterName:"", ManagedFields:[]v1.ManagedFieldsEntry(nil)}, Data:map[string]string(nil), BinaryData:map[string][]uint8(nil)}' due to: 'no kind is registered for the type v1.ConfigMap in scheme "github.com/kinvolk/flatcar-linux-update-operator/pkg/operator/operator.go:161"'. Will not report event: 'Normal' 'LeaderElection' 'flatcar-linux-update-operator-85bd87b458-pfhhx became leader'
Signed-off-by: Mateusz Gozdek <[email protected]>
As binaries should not be committed into git. Signed-off-by: Mateusz Gozdek <[email protected]>
If we don't use vendored dependencies, but use go modules, we run into the issue, when glog is being initialized twice, which results flags being re-defined, which makes the code panic. Signed-off-by: Mateusz Gozdek <[email protected]>
invidian
requested review from
dongsupark,
iaguis,
ipochi,
mauriciovasquezbernal,
pothos,
rata and
surajssd
dongsupark
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done with help from coreos/container-linux-update-operator#197.
CC @betermieux